summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorLennard Kittner <lennard@kittner.dev>2025-03-09 17:02:43 +0100
committerLennard Kittner <lennard@kittner.dev>2025-03-09 17:02:43 +0100
commitd15c19485a0872612090285d58c038cadbebd8d7 (patch)
tree2c3de90c411873ee14f5a723a0b060dccd4905fd /src
parente424488fd998ae442bcd34bfb5358342ad76ce99 (diff)
Fix some warnings
Diffstat (limited to 'src')
-rw-r--r--src/energy.rs3
-rw-r--r--src/energy/budget.rs2
-rw-r--r--src/energy/trackers.rs1
-rw-r--r--src/energy/trackers/kernel.rs2
-rw-r--r--src/scheduler.rs4
5 files changed, 5 insertions, 7 deletions
diff --git a/src/energy.rs b/src/energy.rs
index 64ec267..8400dd7 100644
--- a/src/energy.rs
+++ b/src/energy.rs
@@ -8,14 +8,13 @@ use std::thread;
use std::time::Duration;
use crate::Pid;
-use anyhow::Result;
use dashmap::DashMap;
use crate::energy::rapl::PackageEnergy;
pub use budget::BudgetPolicy;
use perf_event::events::Event;
use perf_event::{Builder, Counter};
-pub use trackers::{Estimator, KernelDriver, MockEstimator, PerfEstimator};
+pub use trackers::{Estimator, KernelDriver, PerfEstimator};
pub enum Request {
NewTask(Pid),
diff --git a/src/energy/budget.rs b/src/energy/budget.rs
index 7a2c7e2..7002dd3 100644
--- a/src/energy/budget.rs
+++ b/src/energy/budget.rs
@@ -31,7 +31,7 @@ impl BudgetPolicy for SimpleCappingPolicy {
// Simple proportional distribution if over cap
if actual_energy > self.power_cap as f64 {
- let ratio = self.power_cap as f64 / actual_energy as f64;
+ let ratio = self.power_cap as f64 / actual_energy;
for (&pid, &energy) in &process_energies {
// Calculate a scaled budget based on the ratio
diff --git a/src/energy/trackers.rs b/src/energy/trackers.rs
index 592c926..31e2f3e 100644
--- a/src/energy/trackers.rs
+++ b/src/energy/trackers.rs
@@ -3,6 +3,7 @@ mod mock;
mod perf;
pub use kernel::*;
+#[allow(unused_imports)]
pub use mock::*;
pub use perf::*;
diff --git a/src/energy/trackers/kernel.rs b/src/energy/trackers/kernel.rs
index 050805c..b71fee6 100644
--- a/src/energy/trackers/kernel.rs
+++ b/src/energy/trackers/kernel.rs
@@ -40,7 +40,7 @@ impl Estimator for KernelDriver {
fn read_consumption(&mut self, pid: u64) -> u64 {
let mut arg = pid;
- if let Ok(_) = READ_POWER.ioctl(&mut self.file, &mut arg) {
+ if READ_POWER.ioctl(&mut self.file, &mut arg).is_ok() {
arg
} else {
0
diff --git a/src/scheduler.rs b/src/scheduler.rs
index 0cc9522..9e13656 100644
--- a/src/scheduler.rs
+++ b/src/scheduler.rs
@@ -7,9 +7,7 @@ use dashmap::DashMap;
use libbpf_rs::OpenObject;
use scx_utils::{Topology, UserExitInfo};
-use std::collections::{HashMap, HashSet, VecDeque};
-use std::fs::File;
-use std::io::{BufRead, BufReader};
+use std::collections::{HashMap, VecDeque};
use std::mem::MaybeUninit;
use std::ops::Range;
use std::process;