<feed xmlns='http://www.w3.org/2005/Atom'>
<title>pm24.git/drivers/net/wireless/rtlwifi, branch v3.15</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.</subtitle>
<id>https://git.kobert.dev/pm24.git/atom/drivers/net/wireless/rtlwifi?h=v3.15</id>
<link rel='self' href='https://git.kobert.dev/pm24.git/atom/drivers/net/wireless/rtlwifi?h=v3.15'/>
<link rel='alternate' type='text/html' href='https://git.kobert.dev/pm24.git/'/>
<updated>2014-04-30T16:22:52Z</updated>
<entry>
<title>rtl8192cu: Fix unbalanced irq enable in error path of rtl92cu_hw_init()</title>
<updated>2014-04-30T16:22:52Z</updated>
<author>
<name>Ben Hutchings</name>
<email>ben@decadent.org.uk</email>
</author>
<published>2014-04-26T20:59:04Z</published>
<link rel='alternate' type='text/html' href='https://git.kobert.dev/pm24.git/commit/?id=3234f5b06fc3094176a86772cc64baf3decc98fc'/>
<id>urn:sha1:3234f5b06fc3094176a86772cc64baf3decc98fc</id>
<content type='text'>
Fixes: a53268be0cb9 ('rtlwifi: rtl8192cu: Fix too long disable of IRQs')
Cc: stable@vger.kernel.org
Signed-off-by: Ben Hutchings &lt;ben@decadent.org.uk&gt;
Signed-off-by: John W. Linville &lt;linville@tuxdriver.com&gt;
</content>
</entry>
<entry>
<title>rtlwifi: rtl8192se: Fix regression due to commit 1bf4bbb</title>
<updated>2014-04-30T16:22:52Z</updated>
<author>
<name>Larry Finger</name>
<email>Larry.Finger@lwfinger.net</email>
</author>
<published>2014-04-25T15:05:43Z</published>
<link rel='alternate' type='text/html' href='https://git.kobert.dev/pm24.git/commit/?id=5f9186990ec4579ee5b7a99b3254c29eda479f36'/>
<id>urn:sha1:5f9186990ec4579ee5b7a99b3254c29eda479f36</id>
<content type='text'>
Beginning with kernel 3.13, this driver fails on some systems. The problem
was bisected to:

Commit 1bf4bbb4024dcdab5e57634dd8ae1072d42a53ac
Author: Felix Fietkau &lt;nbd@openwrt.org&gt;
Title: mac80211: send control port protocol frames to the VO queue

There is noting wrong with the above commit. The regression occurs because
V0 queue on RTL8192SE cards uses priority 6, not the usual 7. The fix is to
modify the rtl8192se routine that sets the correct transmit queue.

Bug: https://bugzilla.kernel.org/show_bug.cgi?id=74541

Reported-by: Alex Miller &lt;almiller_1@yahoo.co.uk&gt;
Tested-by: Alex Miller &lt;almiller_1@yahoo.co.uk&gt;
Signed-off-by: Larry Finger &lt;Larry.Finger@lwfinger.net&gt;
Cc: Stable &lt;stable@vger.kernel.org&gt;    [3.13+]
Signed-off-by: John W. Linville &lt;linville@tuxdriver.com&gt;
</content>
</entry>
<entry>
<title>rtlwifi: rtl8188ee: initialize packet_beacon</title>
<updated>2014-04-22T18:09:37Z</updated>
<author>
<name>Colin Ian King</name>
<email>colin.king@canonical.com</email>
</author>
<published>2014-04-21T16:38:44Z</published>
<link rel='alternate' type='text/html' href='https://git.kobert.dev/pm24.git/commit/?id=328e203fc35f0b4f6df1c4943f74cf553bcc04f8'/>
<id>urn:sha1:328e203fc35f0b4f6df1c4943f74cf553bcc04f8</id>
<content type='text'>
static code analysis from cppcheck reports:

[drivers/net/wireless/rtlwifi/rtl8188ee/trx.c:322]:
  (error) Uninitialized variable: packet_beacon

packet_beacon is not initialized and hence packet_beacon
contains garbage from the stack, so set it to false.

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Cc: Stable &lt;stable@vger.kernel.org&gt; [3.10+]
Acked-by: Larry Finger &lt;Larry.Finger@lwfinger.net&gt;
Signed-off-by: John W. Linville &lt;linville@tuxdriver.com&gt;
</content>
</entry>
<entry>
<title>rtlwifi: btcoexist: remove undefined Kconfig macros</title>
<updated>2014-04-09T17:55:54Z</updated>
<author>
<name>Paul Bolle</name>
<email>pebolle@tiscali.nl</email>
</author>
<published>2014-04-03T08:12:51Z</published>
<link rel='alternate' type='text/html' href='https://git.kobert.dev/pm24.git/commit/?id=5212f518ac0f5141d4da3c9c75666a2146c7e772'/>
<id>urn:sha1:5212f518ac0f5141d4da3c9c75666a2146c7e772</id>
<content type='text'>
There are references to four undefined Kconfig macros in the code.
Commit 8542373dccd2 ("Staging: rtl8812ae: remove undefined Kconfig
macros") removed identical references from that staging driver, but
they resurfaced in rtlwifi. Remove these again as the checks for them
still will always evaluate to false.

Signed-off-by: Paul Bolle &lt;pebolle@tiscali.nl&gt;
Signed-off-by: John W. Linville &lt;linville@tuxdriver.com&gt;
</content>
</entry>
<entry>
<title>rtlwifi: rtl8188ee: enable MSI interrupts mode</title>
<updated>2014-03-31T17:47:41Z</updated>
<author>
<name>Adam Lee</name>
<email>adam.lee@canonical.com</email>
</author>
<published>2014-03-28T03:36:19Z</published>
<link rel='alternate' type='text/html' href='https://git.kobert.dev/pm24.git/commit/?id=2a54eb5e1476426ee639bbfbe179b52342a0d82c'/>
<id>urn:sha1:2a54eb5e1476426ee639bbfbe179b52342a0d82c</id>
<content type='text'>
Some HP notebooks using this rtl8188ee hardware module can't get
AP scan results with pin-based interrupts mode, enabling MSI interrupts
mode could fix it.

As RealTek's testing results, RTL8188EE works well with both MSI mode
and pin-based mode fallback.

Signed-off-by: Adam Lee &lt;adam.lee@canonical.com&gt;
Signed-off-by: John W. Linville &lt;linville@tuxdriver.com&gt;
</content>
</entry>
<entry>
<title>rtlwifi: add MSI interrupts mode support</title>
<updated>2014-03-31T17:47:41Z</updated>
<author>
<name>Adam Lee</name>
<email>adam.lee@canonical.com</email>
</author>
<published>2014-03-28T03:36:18Z</published>
<link rel='alternate' type='text/html' href='https://git.kobert.dev/pm24.git/commit/?id=94010fa0dd07e8b904e7c6b6589f15573008ab15'/>
<id>urn:sha1:94010fa0dd07e8b904e7c6b6589f15573008ab15</id>
<content type='text'>
Add MSI interrupts mode support, enable it when submodules' msi_support
flag is true, also could fallback to pin-based interrupts mode if MSI
interrupts mode fails.

RealTek's policy(on modules which work well with MSI interrupts mode) is:

&gt; If the platform supports both MSI and pin-based, use MSI.
&gt; If the platform supports MSI only, use MSI.
&gt; If the platform supports pin-based only, use pin-based.

Also as RealTek's testing results, RTL8188EE and RTL8723BE work well
with both MSI mode and pin-based mode fallback.

Signed-off-by: Adam Lee &lt;adam.lee@canonical.com&gt;
Signed-off-by: John W. Linville &lt;linville@tuxdriver.com&gt;
</content>
</entry>
<entry>
<title>rtlwifi: Remove casts of pointer to same type</title>
<updated>2014-03-27T18:20:05Z</updated>
<author>
<name>Joe Perches</name>
<email>joe@perches.com</email>
</author>
<published>2014-03-24T20:15:40Z</published>
<link rel='alternate' type='text/html' href='https://git.kobert.dev/pm24.git/commit/?id=1851cb4a0f08ba0600103203c4b52e53c744f59c'/>
<id>urn:sha1:1851cb4a0f08ba0600103203c4b52e53c744f59c</id>
<content type='text'>
Casting a pointer to a pointer of the same type is pointless,
so remove these unnecessary casts.

Around these changes:

o Remove unnecessary parentheses
o Use consistent dereference style (change ptr[0] to *ptr)
o Argument alignment

Done via coccinelle script: (and some typing)

$ cat typecast_2.cocci
@@
type T;
T *foo;
@@

-	(T *)foo
+	foo

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Signed-off-by: John W. Linville &lt;linville@tuxdriver.com&gt;
</content>
</entry>
<entry>
<title>rtlwifi: Remove addressof casts to same type</title>
<updated>2014-03-27T18:20:05Z</updated>
<author>
<name>Joe Perches</name>
<email>joe@perches.com</email>
</author>
<published>2014-03-24T17:46:20Z</published>
<link rel='alternate' type='text/html' href='https://git.kobert.dev/pm24.git/commit/?id=9cb76aa994682c7a5584cf4a03aeedd7ef1204bd'/>
<id>urn:sha1:9cb76aa994682c7a5584cf4a03aeedd7ef1204bd</id>
<content type='text'>
Using addressof then casting to the original type is pointless,
so remove these unnecessary casts.

Done via coccinelle script:

$ cat typecast.cocci
@@
type T;
T foo;
@@

-	(T *)&amp;foo
+	&amp;foo

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Signed-off-by: John W. Linville &lt;linville@tuxdriver.com&gt;
</content>
</entry>
<entry>
<title>rtlwifi: rtl8723be: Fix array dimension problems</title>
<updated>2014-03-13T18:05:40Z</updated>
<author>
<name>Larry Finger</name>
<email>Larry.Finger@lwfinger.net</email>
</author>
<published>2014-03-10T23:53:10Z</published>
<link rel='alternate' type='text/html' href='https://git.kobert.dev/pm24.git/commit/?id=4e3b3bcd81776527fa6f11624d68849de8c8802e'/>
<id>urn:sha1:4e3b3bcd81776527fa6f11624d68849de8c8802e</id>
<content type='text'>
Commit a619d1abe20c leads to the following static checker warning:

drivers/net/wireless/rtlwifi/rtl8723be/phy.c:667 _rtl8723be_store_tx_power_by_rate()
error: buffer overflow 'rtlphy-&gt;tx_power_by_rate_offset[band]' 4 &lt;= 5

This warning arises because the code is testing the indices for the wrong maximum
values. In addition, the tests merely putput a warning, and then procedes to
corrupt memory. With this change, any such invalid memory access is avoided.

Signed-off-by: Larry Finger &lt;Larry.Finger@lwfinger.net&gt;
Reported-by: Dan Carpenter &lt;dan.carpenter@oracle.com&gt;
Signed-off-by: John W. Linville &lt;linville@tuxdriver.com&gt;
</content>
</entry>
<entry>
<title>rtlwifi: rtl8723be: Fix smatch warnings</title>
<updated>2014-03-06T19:29:57Z</updated>
<author>
<name>Larry Finger</name>
<email>Larry.Finger@lwfinger.net</email>
</author>
<published>2014-03-05T23:26:01Z</published>
<link rel='alternate' type='text/html' href='https://git.kobert.dev/pm24.git/commit/?id=7ce24ab74c04ce0ce238b5dce30e9bc3823527be'/>
<id>urn:sha1:7ce24ab74c04ce0ce238b5dce30e9bc3823527be</id>
<content type='text'>
Smatch reports the following:

drivers/net/wireless/rtlwifi/rtl8723be/fw.c:208 _rtl8723be_fill_h2c_command() warn: variable dereferenced before check 'rtlhal' (see line 69)
drivers/net/wireless/rtlwifi/rtl8723be/hw.c:1732 _rtl8723be_read_adapter_info() error: __builtin_memcpy() '&amp;rtlefuse-&gt;efuse_map[0][0]' too small (256 vs 512)

The first one is fixed by removing two pointless tests for NULL pointers.

Reported-by: Dan Carpenter &lt;dan.carpenter@oracle.com&gt;
Signed-off-by: Larry Finger &lt;Larry.Finger@lwfinger.net&gt;
Signed-off-by: John W. Linville &lt;linville@tuxdriver.com&gt;
</content>
</entry>
</feed>
