pm24.git/drivers/staging/comedi, branch v3.14

staging: comedi: usbduxsigma: fix unaligned dereferences

2014-02-07T19:08:46Z

There are a couple of dereferences such as `*(uint32_t *)(devpriv->insn_buf + 1)` that are unaligned as `devpriv->insn_buf` is of type `uint8_t *`. This works on x86 architecture but may not be supported on other architectures. Call `get_unalign()` to perform the unaligned dereferences. Signed-off-by: Ian Abbott Cc: Bernd Porr Signed-off-by: Greg Kroah-Hartman

staging: comedi: fix too early cleanup in comedi_auto_config()

2014-02-07T19:08:46Z

`comedi_auto_config()` is usually called from the probe routine of a low-level comedi driver to allocate and auto-configure a comedi device. Part of this involves calling the low-level driver's `auto_attach()` handler, and if that is successful, `comedi_device_postconfig()` tries to complete the configuration of the comedi device. If either of those fail, `comedi_device_detach()` is called to clean up, and `comedi_release_hardware_device()` is called to remove the dynamically allocated comedi device. Unfortunately, `comedi_device_detach()` clears the `hw_dev` member of the `struct comedi_device` (indirectly via `comedi_clear_hw_dev()`), and that stops `comedi_release_hardware_device()` finding the comedi device associated with the hardware device, so the comedi device won't be removed properly. Since `comedi_release_hardware_device()` also calls `comedi_device_detach()` (assuming it finds the comedi device associated with the hardware device), the fix is to remove the direct call to `comedi_device_detach()` from `comedi_auto_config()` and let the call to `comedi_release_hardware_device()` take care of it. Signed-off-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman

staging: comedi: adv_pci1710: fix analog output readback value

2014-02-07T17:19:30Z

The last value written to a analog output channel is cached in the private data of this driver for readback. Currently, the wrong value is cached in the (*insn_write) functions. The current code stores the data[n] value for readback afer the loop has written all the values. At this time 'n' points past the end of the data array. Fix the functions by using a local variable to hold the data being written to the analog output channel. This variable is then used after the loop is complete to store the readback value. The current value is retrieved before the loop in case no values are actually written.. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Cc: stable Signed-off-by: Greg Kroah-Hartman

Staging: comedi: fix extra whitespace style issues in ni_mio_common.c.

2014-01-13T23:04:52Z

This patch for ni_mio_common.c removes extra whitespace causing checkpatch.pl warnings. Signed-off-by: Chase Southwood Signed-off-by: Greg Kroah-Hartman

Staging: comedi: fix indentation coding style issue in ni_mio_common.c.

2014-01-13T23:04:52Z

This patch for ni_mio_common.c fixes several indentation warnings from checkpatch.pl. Signed-off-by: Chase Southwood Signed-off-by: Greg Kroah-Hartman

Staging: comedi: fix numerous brace coding style issues in ni_mio_common.c.

2014-01-13T23:04:52Z

This patch for ni_mio_common.c removes many unneccesary braces to fix checkpatch.pl warnings. Signed-off-by: Chase Southwood Signed-off-by: Greg Kroah-Hartman

comedi: Humusoft MF634 and MF624 DAQ cards driver

2014-01-13T23:03:12Z

This patch adds Comedi driver for Humusoft MF634 (PCIe) and MF624 (PCI) data acquisition cards. The legacy card Humusoft MF614 is not supported. More info about the cards may be found at http://humusoft.cz/produkty/datacq/ The driver was tested with both cards. Everything seems to work properly. Just the basic functionality of the card (DIO, ADC, DAC) is supported by this driver. Signed-off-by: Rostislav Lisovy Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman

Staging: comedi: amcc_s5933: "no space before tabs" coding style fixes.

2014-01-11T20:41:56Z

Fixed a coding style issues. Signed-off-by: Michal Kwiatkowski Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman

Staging: comedi: fix spacing coding style issue in 8255.c.

2014-01-11T20:41:56Z

This patch for 8255.c fixes a spacing warning found by checkpatch.pl. Signed-off-by: Chase Southwood Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman

staging: comedi: usbduxsigma: removing unneccesay attached info

2014-01-09T18:51:54Z

Comedi core now reports that a device has been attached so that the driver itself won't need to do it any longer. The driver now just outputs the offset of the ADC converter which is a soft indicator of the health of the board and also the user can grep this value from the kernel log easier for debugging purposes. Signed-off-by: Bernd Porr Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman