pm24.git/drivers/video/fbdev/omap2, branch rust-6.8Unnamed repository; edit this file 'description' to name the repository.
https://git.kobert.dev/pm24.git/atom?h=rust-6.82023-11-10T06:34:19Zfbdev: omapfb/tpd12s015: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:18:03Zurn:sha1:2e2389ca5d7efd2f029b138d78e38200d5ba125b
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/tfp410: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:18:02Zurn:sha1:a23f29d057d034c77bd6689a5c328a6933255bf4
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/sharp-ls037v7dw01: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:18:01Zurn:sha1:b0d61e8c04965373b74d719a460153cb700dab80
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/opa362: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:18:00Zurn:sha1:fe83fc52db06aa0632e53b3b27184e26971b555d
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/hdmi: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:17:59Zurn:sha1:34948a36a4bbf583bf39b5c9783aa9e872c7910d
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/dvi: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:17:58Zurn:sha1:ebfb1334cf430ef36059c5bed35e9cfbab23ff11
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/dsi-cm: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:17:57Zurn:sha1:da21ff3954ed31e04f8280b3ef573484c38e01ad
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/dpi: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:17:56Zurn:sha1:d5d8b9df6b6d72841f827327b37de2b0b7af88f2
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/analog-tv: Convert to platform remove callback returning void2023-11-10T06:34:19ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:17:55Zurn:sha1:26553eb8df2dbfbc075619abd53618efc8c5586a
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
fbdev: omapfb/tpd12s015: Don't put .remove() in .exit.text and drop suppress_bind_attrs2023-11-10T06:34:18ZUwe Kleine-Königu.kleine-koenig@pengutronix.de2023-11-07T09:17:52Zurn:sha1:3e9ec97706fd8bc06ed41ff85ff168537618879f
On today's platforms the memory savings of putting the remove function
in .exit isn't that relevant any more. It only matters for built-in
drivers and typically saves a few 100k.
The downside is that the driver cannot be unbound at runtime which is
ancient and also slightly complicates testing. Also it requires to mark
the driver struct with __refdata which is needed to suppress a (W=1)
modpost warning:
WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015: section mismatch in reference: tpd_driver+0x4 (section: .data) -> tpd_remove (section: .exit.text)
To simplify matters, move the remove callback to .text and drop
.suppress_bind_attrs = true.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>