pm24.git/include/linux/sunrpc/auth.h, branch v5.0-rc3

SUNRPC discard cr_uid from struct rpc_cred.

2018-12-19T18:52:46Z

Just use ->cr_cred->fsuid directly. Signed-off-by: NeilBrown Signed-off-by: Anna Schumaker

SUNRPC: remove crbind rpc_cred operation

2018-12-19T18:52:46Z

This now always just does get_rpccred(), so we don't need an operation pointer to know to do that. Signed-off-by: NeilBrown Signed-off-by: Anna Schumaker

SUNRPC: remove generic cred code.

2018-12-19T18:52:46Z

This is no longer used. Signed-off-by: NeilBrown Signed-off-by: Anna Schumaker

NFS/NFSD/SUNRPC: replace generic creds with 'struct cred'.

2018-12-19T18:52:46Z

SUNRPC has two sorts of credentials, both of which appear as "struct rpc_cred". There are "generic credentials" which are supplied by clients such as NFS and passed in 'struct rpc_message' to indicate which user should be used to authorize the request, and there are low-level credentials such as AUTH_NULL, AUTH_UNIX, AUTH_GSS which describe the credential to be sent over the wires. This patch replaces all the generic credentials by 'struct cred' pointers - the credential structure used throughout Linux. For machine credentials, there is a special 'struct cred *' pointer which is statically allocated and recognized where needed as having a special meaning. A look-up of a low-level cred will map this to a machine credential. Signed-off-by: NeilBrown Acked-by: J. Bruce Fields Signed-off-by: Anna Schumaker

SUNRPC: remove RPCAUTH_AUTH_NO_CRKEY_TIMEOUT

2018-12-19T18:52:45Z

This is no longer used. Signed-off-by: NeilBrown Signed-off-by: Anna Schumaker

NFS: move credential expiry tracking out of SUNRPC into NFS.

2018-12-19T18:52:45Z

NFS needs to know when a credential is about to expire so that it can modify write-back behaviour to finish the write inside the expiry time. It currently uses functions in SUNRPC code which make use of a fairly complex callback scheme and flags in the generic credientials. As I am working to discard the generic credentials, this has to change. This patch moves the logic into NFS, in part by finding and caching the low-level credential in the open_context. We then make direct cred-api calls on that. This makes the code much simpler and removes a dependency on generic rpc credentials. Signed-off-by: NeilBrown Signed-off-by: Anna Schumaker

NFS/SUNRPC: don't lookup machine credential until rpcauth_bindcred().

2018-12-19T18:52:45Z

When NFS creates a machine credential, it is a "generic" credential, not tied to any auth protocol, and is really just a container for the princpal name. This doesn't get linked to a genuine credential until rpcauth_bindcred() is called. The lookup always succeeds, so various places that test if the machine credential is NULL, are pointless. As a step towards getting rid of generic credentials, this patch gets rid of generic machine credentials. The nfs_client and rpc_client just hold a pointer to a constant principal name. When a machine credential is wanted, a special static 'struct rpc_cred' pointer is used. rpcauth_bindcred() recognizes this, finds the principal from the client, and binds the correct credential. Signed-off-by: NeilBrown Signed-off-by: Anna Schumaker

SUNRPC: remove machine_cred field from struct auth_cred

2018-12-19T18:52:45Z

The cred is a machine_cred iff ->principal is set, so there is no need for the extra flag. There is one case which deserves some explanation. nfs4_root_machine_cred() calls rpc_lookup_machine_cred() with a NULL principal name which results in not getting a machine credential, but getting a root credential instead. This appears to be what is expected of the caller, and is clearly the result provided by both auth_unix and auth_gss which already ignore the flag. Signed-off-by: NeilBrown Signed-off-by: Anna Schumaker

SUNRPC: remove uid and gid from struct auth_cred

2018-12-19T18:52:45Z

Use cred->fsuid and cred->fsgid instead. Signed-off-by: NeilBrown Signed-off-by: Anna Schumaker

SUNRPC: remove groupinfo from struct auth_cred.

2018-12-19T18:52:45Z

We can use cred->groupinfo (from the 'struct cred') instead. Signed-off-by: NeilBrown Signed-off-by: Anna Schumaker