summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Howells <dhowells@redhat.com>2020-06-16 00:52:30 +0100
committerDavid Howells <dhowells@redhat.com>2020-06-16 16:26:57 +0100
commit7c295eec1e351003a8ca06c34f9e79336fa5b244 (patch)
tree44e36fedd105e3b432415c8c3cfa4ccfb9640417
parent728279a5a1fd9fa9fa268f807391c4d19ad2822c (diff)
afs: afs_vnode_commit_status() doesn't need to check the RPC error
afs_vnode_commit_status() is only ever called if op->error is 0, so remove the op->error checks from the function. Fixes: e49c7b2f6de7 ("afs: Build an abstraction around an "operation" concept") Signed-off-by: David Howells <dhowells@redhat.com>
-rw-r--r--fs/afs/inode.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/afs/inode.c b/fs/afs/inode.c
index 56e60d561f37..d5d0ae7b2b1e 100644
--- a/fs/afs/inode.c
+++ b/fs/afs/inode.c
@@ -281,8 +281,6 @@ void afs_vnode_commit_status(struct afs_operation *op, struct afs_vnode_param *v
_enter("");
- ASSERTCMP(op->error, ==, 0);
-
write_seqlock(&vnode->cb_lock);
if (vp->scb.have_error) {
@@ -300,7 +298,7 @@ void afs_vnode_commit_status(struct afs_operation *op, struct afs_vnode_param *v
write_sequnlock(&vnode->cb_lock);
- if (op->error == 0 && vp->scb.have_status)
+ if (vp->scb.have_status)
afs_cache_permit(vnode, op->key, vp->cb_break_before, &vp->scb);
}