diff options
| author | Florian Fainelli <f.fainelli@gmail.com> | 2018-09-28 16:18:54 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-09-29 11:31:29 -0700 |
| commit | f2750df1548bd8a2b060eb609fc43ca82811af4c (patch) | |
| tree | 5cbea3a809abfc1abe0689ea6739c96f3606260d | |
| parent | c5cb93e994ffb43b7b3b1ff10b9f928f54574a36 (diff) | |
r8152: Check for supported Wake-on-LAN Modes
The driver does not check for Wake-on-LAN modes specified by an user,
but will conditionally set the device as wake-up enabled or not based on
that, which could be a very confusing user experience.
Fixes: 21ff2e8976b1 ("r8152: support WOL")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/usb/r8152.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 2cd71bdb6484..f1b5201cc320 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -4506,6 +4506,9 @@ static int rtl8152_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol) if (!rtl_can_wakeup(tp)) return -EOPNOTSUPP; + if (wol->wolopts & ~WAKE_ANY) + return -EINVAL; + ret = usb_autopm_get_interface(tp->intf); if (ret < 0) goto out_set_wol; |