diff options
author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2020-02-11 15:10:10 -0600 |
---|---|---|
committer | Sudeep Holla <sudeep.holla@arm.com> | 2020-02-20 17:15:04 +0000 |
commit | 57c45d4d8a9d78c962e9ddfc4fb2d3210f34f966 (patch) | |
tree | 27f815627a229d51789372e84022aa08e76dbf8b | |
parent | 539db76293cd2e73fe798ed0f21ac852351fedd8 (diff) |
misc: vexpress: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Replace the zero-length member "template" in vexpress_syscfg_func
structure with flexible-array.
Link: https://lore.kernel.org/r/20200211211010.GA32239@embeddedor
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
-rw-r--r-- | drivers/misc/vexpress-syscfg.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/vexpress-syscfg.c b/drivers/misc/vexpress-syscfg.c index 058fcd7f9f01..a431787c0898 100644 --- a/drivers/misc/vexpress-syscfg.c +++ b/drivers/misc/vexpress-syscfg.c @@ -42,7 +42,7 @@ struct vexpress_syscfg_func { struct vexpress_syscfg *syscfg; struct regmap *regmap; int num_templates; - u32 template[0]; /* Keep it last! */ + u32 template[]; /* Keep it last! */ }; |