diff options
| author | Mark Rutland <mark.rutland@arm.com> | 2021-11-29 13:06:46 +0000 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2021-12-01 00:06:43 +0100 |
| commit | 7fb2b24bb5c5876a3205cb5b9a580f81e8c9f744 (patch) | |
| tree | 38b8491a93445a4ea2b3454f077b1d70062888d2 /arch/alpha | |
| parent | 0569b245132c40015281610353935a50e282eb94 (diff) | |
alpha: Snapshot thread flags
Some thread flags can be set remotely, and so even when IRQs are disabled,
the flags can change under our feet. Generally this is unlikely to cause a
problem in practice, but it is somewhat unsound, and KCSAN will
legitimately warn that there is a data race.
To avoid such issues, a snapshot of the flags has to be taken prior to
using them. Some places already use READ_ONCE() for that, others do not.
Convert them all to the new flag accessor helpers.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Matt Turner <mattst88@gmail.com>
Cc: Richard Henderson <rth@twiddle.net>
Link: https://lore.kernel.org/r/20211129130653.2037928-5-mark.rutland@arm.com
Diffstat (limited to 'arch/alpha')
| -rw-r--r-- | arch/alpha/kernel/signal.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/alpha/kernel/signal.c b/arch/alpha/kernel/signal.c index bc077babafab..d8ed71d5bed3 100644 --- a/arch/alpha/kernel/signal.c +++ b/arch/alpha/kernel/signal.c @@ -535,6 +535,6 @@ do_work_pending(struct pt_regs *regs, unsigned long thread_flags, } } local_irq_disable(); - thread_flags = current_thread_info()->flags; + thread_flags = read_thread_flags(); } while (thread_flags & _TIF_WORK_MASK); } |