diff options
author | Tejun Heo <tj@kernel.org> | 2022-03-14 14:30:11 -1000 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2022-03-14 19:14:37 -0600 |
commit | 6b2b04590b51aa4cf395fcd185ce439cab5961dc (patch) | |
tree | ca7f907498c68799e2f0ddb8e128464012a26b60 /block/blk-rq-qos.h | |
parent | aa1b46dcdc7baaf5fec0be25782ef24b26aa209e (diff) |
block: don't merge across cgroup boundaries if blkcg is enabled
blk-iocost and iolatency are cgroup aware rq-qos policies but they didn't
disable merges across different cgroups. This obviously can lead to
accounting and control errors but more importantly to priority inversions -
e.g. an IO which belongs to a higher priority cgroup or IO class may end up
getting throttled incorrectly because it gets merged to an IO issued from a
low priority cgroup.
Fix it by adding blk_cgroup_mergeable() which is called from merge paths and
rejects cross-cgroup and cross-issue_as_root merges.
Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: d70675121546 ("block: introduce blk-iolatency io controller")
Cc: stable@vger.kernel.org # v4.19+
Cc: Josef Bacik <jbacik@fb.com>
Link: https://lore.kernel.org/r/Yi/eE/6zFNyWJ+qd@slm.duckdns.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-rq-qos.h')
0 files changed, 0 insertions, 0 deletions