diff options
| author | Xing Tong Wu <xingtong.wu@siemens.com> | 2023-11-21 16:16:04 +0800 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2023-12-11 06:21:00 -0800 |
| commit | 8b3800256abad20e91c2698607f9b28591407b19 (patch) | |
| tree | a1221479046f20b59e2c9587db866e05463bca2b /drivers/hwmon | |
| parent | ff629afe7ffdfdfee15c75e9a22c67d316338cc5 (diff) | |
hwmon: (nct6775) Fix fan speed set failure in automatic mode
Setting the fan speed is only valid in manual mode; it is not possible
to set the fan's speed in automatic mode.
Return error when attempting to set the fan speed in automatic mode.
Signed-off-by: Xing Tong Wu <xingtong.wu@siemens.com>
Link: https://lore.kernel.org/r/20231121081604.2499-3-xingtong_wu@163.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/nct6775-core.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/hwmon/nct6775-core.c b/drivers/hwmon/nct6775-core.c index 49f8e4a7beaf..8d2ef3145bca 100644 --- a/drivers/hwmon/nct6775-core.c +++ b/drivers/hwmon/nct6775-core.c @@ -2553,6 +2553,13 @@ store_pwm(struct device *dev, struct device_attribute *attr, const char *buf, int err; u16 reg; + /* + * The fan control mode should be set to manual if the user wants to adjust + * the fan speed. Otherwise, it will fail to set. + */ + if (index == 0 && data->pwm_enable[nr] > manual) + return -EBUSY; + err = kstrtoul(buf, 10, &val); if (err < 0) return err; |