diff options
| author | David Christensen <drc@linux.vnet.ibm.com> | 2023-09-14 18:02:52 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-09-16 11:42:11 +0100 |
| commit | 8f6b846b0a86c3cbae8a25b772651cfc2270ad0a (patch) | |
| tree | 53de141c4edd6a072cc85bf3955e7f4ea88ef4cd /drivers/net/ethernet/intel/igc/igc_main.c | |
| parent | 1612cc4b1433996ca5549c05a536bbd5ba59e03c (diff) | |
ionic: fix 16bit math issue when PAGE_SIZE >= 64KB
The ionic device supports a maximum buffer length of 16 bits (see
ionic_rxq_desc or ionic_rxq_sg_elem). When adding new buffers to
the receive rings, the function ionic_rx_fill() uses 16bit math when
calculating the number of pages to allocate for an RX descriptor,
given the interface's MTU setting. If the system PAGE_SIZE >= 64KB,
and the buf_info->page_offset is 0, the remain_len value will never
decrement from the original MTU value and the frag_len value will
always be 0, causing additional pages to be allocated as scatter-
gather elements unnecessarily.
A similar math issue exists in ionic_rx_frags(), but no failures
have been observed here since a 64KB page should not normally
require any scatter-gather elements at any legal Ethernet MTU size.
Fixes: 4b0a7539a372 ("ionic: implement Rx page reuse")
Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/intel/igc/igc_main.c')
0 files changed, 0 insertions, 0 deletions