diff options
| author | Tom Rix <trix@redhat.com> | 2023-02-06 05:58:31 -0800 |
|---|---|---|
| committer | Bjorn Andersson <andersson@kernel.org> | 2023-02-06 12:25:00 -0800 |
| commit | dcb4e7a57cbe8d85e4927f517ae28aab17596419 (patch) | |
| tree | 1b09ca8e30024a0510d799516f1561b430cac4cd /drivers | |
| parent | acdbf5f9b2c492505145f6e50c65418521a547c4 (diff) | |
soc: qcom: pmic_glink: remove redundant calculation of svid
gcc with W=1 reports
drivers/soc/qcom/pmic_glink_altmode.c:223:13: error: variable ‘svid’ set but not used [-Werror=unused-but-set-variable]
223 | u16 svid;
From reviewing the code, the setting of alt_port->svid does the same calculation.
Both are not needed. For debuggablity, keep the setting of local svid.
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230206135831.1794583-1-trix@redhat.com
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/soc/qcom/pmic_glink_altmode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/soc/qcom/pmic_glink_altmode.c b/drivers/soc/qcom/pmic_glink_altmode.c index 71f861b8cb51..4d7895bdeaf2 100644 --- a/drivers/soc/qcom/pmic_glink_altmode.c +++ b/drivers/soc/qcom/pmic_glink_altmode.c @@ -248,7 +248,7 @@ static void pmic_glink_altmode_sc8180xp_notify(struct pmic_glink_altmode *altmod alt_port = &altmode->ports[port]; alt_port->orientation = pmic_glink_altmode_orientation(orientation); - alt_port->svid = mux == 2 ? USB_TYPEC_DP_SID : 0; + alt_port->svid = svid; alt_port->mode = mode; alt_port->hpd_state = hpd_state; alt_port->hpd_irq = hpd_irq; |