diff options
| author | David Howells <dhowells@redhat.com> | 2023-10-31 16:30:37 +0000 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2024-01-01 16:37:27 +0000 |
| commit | f49b594df3ebca53c91f4d6448680463f10aa479 (patch) | |
| tree | d18f0048178320274cf73b7e62c4cbb3a8ae9b80 /fs/afs/vl_probe.c | |
| parent | e6a7d7f71b17e0a44e2155bdad47eae7b5368503 (diff) | |
afs: Keep a record of the current fileserver endpoint state
Keep a record of the current fileserver endpoint state, including the probe
state, and replace it when a new probe is started rather than just
squelching the old state and overwriting it. Clearance of the old state
can cause a race if there's another thread also currently trying to
communicate with that server.
It appears that this race might be the culprit for some occasions where
kafs complains about invalid data in the RPC reply because the rotation
algorithm fell all the way through without actually issuing an RPC call and
the error return got filled in from the probe state (which has a zero error
recorded). Whatever happens to be in the caller's reply buffer is then
taken as the response.
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Diffstat (limited to 'fs/afs/vl_probe.c')
| -rw-r--r-- | fs/afs/vl_probe.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/afs/vl_probe.c b/fs/afs/vl_probe.c index b128dc3d8af7..3d2e0c925460 100644 --- a/fs/afs/vl_probe.c +++ b/fs/afs/vl_probe.c @@ -46,7 +46,7 @@ static void afs_done_one_vl_probe(struct afs_vlserver *server, bool wake_up) */ void afs_vlserver_probe_result(struct afs_call *call) { - struct afs_addr_list *alist = call->probe_alist; + struct afs_addr_list *alist = call->vl_probe; struct afs_vlserver *server = call->vlserver; struct afs_address *addr = &alist->addrs[call->probe_index]; unsigned int server_index = call->server_index; |