diff options
| author | Josef Bacik <josef@toxicpanda.com> | 2023-02-07 11:57:22 -0500 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2023-04-17 18:01:13 +0200 |
| commit | a13bb2c03848e4f96f10486ba0b76f8d398bc71c (patch) | |
| tree | 33bef2fdb64e176343c41dab4b2205dc891d5255 /fs/btrfs/inode.c | |
| parent | 9cf14029d5fb42126b332aea708b787be9a5079e (diff) | |
btrfs: add missing iputs on orphan cleanup failure
We missed a couple of iput()s in the orphan cleanup failure paths, add
them so we don't get refcount errors. The iput needs to be done in the
check and not under a common label due to the way the code is
structured.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/inode.c')
| -rw-r--r-- | fs/btrfs/inode.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 957e4d76a7b6..5dbb4aa4b10f 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -3691,6 +3691,7 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) trans = btrfs_start_transaction(root, 1); if (IS_ERR(trans)) { ret = PTR_ERR(trans); + iput(inode); goto out; } btrfs_debug(fs_info, "auto deleting %Lu", @@ -3698,8 +3699,10 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) ret = btrfs_del_orphan_item(trans, root, found_key.objectid); btrfs_end_transaction(trans); - if (ret) + if (ret) { + iput(inode); goto out; + } continue; } |