diff options
| author | Steve French <stfrench@microsoft.com> | 2021-06-19 12:01:37 -0500 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2021-06-20 21:28:17 -0500 |
| commit | 3559134eccad022fc4a5a56910e8f7d38ab0d30d (patch) | |
| tree | 5977583399cc99603bf9de4b0c43268a01cf216b /fs/cifs/smb2pdu.c | |
| parent | 929be906fa83151c4c77c07cd3d780439d38b153 (diff) | |
cifs: fix unneeded null check
tcon can not be null in SMB2_tcon function so the check
is not relevant and removing it makes Coverity happy.
Acked-by: Ronnie Sahlberg <lsahlber@redhat.com>
Addresses-Coverity: 13250131 ("Dereference before null check")
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs/smb2pdu.c')
| -rw-r--r-- | fs/cifs/smb2pdu.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index 29b729de2b27..0005989d281a 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c @@ -1779,10 +1779,8 @@ SMB2_tcon(const unsigned int xid, struct cifs_ses *ses, const char *tree, rsp = (struct smb2_tree_connect_rsp *)rsp_iov.iov_base; trace_smb3_tcon(xid, tcon->tid, ses->Suid, tree, rc); if (rc != 0) { - if (tcon) { - cifs_stats_fail_inc(tcon, SMB2_TREE_CONNECT_HE); - tcon->need_reconnect = true; - } + cifs_stats_fail_inc(tcon, SMB2_TREE_CONNECT_HE); + tcon->need_reconnect = true; goto tcon_error_exit; } |