diff options
| author | Alexander Aring <aahringo@redhat.com> | 2024-04-17 15:13:22 -0400 |
|---|---|---|
| committer | David Teigland <teigland@redhat.com> | 2024-04-17 14:20:04 -0500 |
| commit | 7b012732d005fba22912dda038dd253e3b9a1bfc (patch) | |
| tree | 7093ab567d97a4f508c8f4f00b02d057cbe0677d /fs/dlm/lockspace.c | |
| parent | 15fd7e55177a8d6243096bb6b9536cd15f56d547 (diff) | |
dlm: fix sleep in atomic context
This patch changes the orphans mutex to a spinlock since commit
c288745f1d4a ("dlm: avoid blocking receive at the end of recovery") is
using a rwlock_t to lock the DLM message receive path and do_purge() can
be called while this lock is held that forbids to sleep.
We need to use spin_lock_bh() because also a user context that calls
dlm_user_purge() can call do_purge() and since commit 92d59adfaf71
("dlm: do message processing in softirq context") the DLM message
receive path is done under softirq context.
Fixes: c288745f1d4a ("dlm: avoid blocking receive at the end of recovery")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/gfs2/9ad928eb-2ece-4ad9-a79c-d2bce228e4bc@moroto.mountain/
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
Diffstat (limited to 'fs/dlm/lockspace.c')
| -rw-r--r-- | fs/dlm/lockspace.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c index 5ce26882159e..ed23787271b1 100644 --- a/fs/dlm/lockspace.c +++ b/fs/dlm/lockspace.c @@ -436,7 +436,7 @@ static int new_lockspace(const char *name, const char *cluster, INIT_LIST_HEAD(&ls->ls_waiters); spin_lock_init(&ls->ls_waiters_lock); INIT_LIST_HEAD(&ls->ls_orphans); - mutex_init(&ls->ls_orphans_mutex); + spin_lock_init(&ls->ls_orphans_lock); INIT_LIST_HEAD(&ls->ls_new_rsb); spin_lock_init(&ls->ls_new_rsb_spin); |