diff options
| author | Bob Peterson <rpeterso@redhat.com> | 2023-05-04 13:43:22 -0400 |
|---|---|---|
| committer | Andreas Gruenbacher <agruenba@redhat.com> | 2023-06-06 18:35:06 +0200 |
| commit | 9b620429eca9a1dbadf6cf983b11d2cb427411ce (patch) | |
| tree | 2a82476c0f531babace3ada208e6bd4a4f83c6cc /fs/gfs2 | |
| parent | e4f82bf21f2586aa823fd40de72023236062a4aa (diff) | |
gfs2: ignore rindex_update failure in dinode_dealloc
Before this patch, function gfs2_dinode_dealloc would abort if it got a
bad return code from gfs2_rindex_update(). The problem is that it left the
dinode in the unlinked (not free) state, which meant subsequent fsck
would clean it up and flag an error. That meant some of our QE tests
would fail.
The sole purpose of gfs2_rindex_update(), in this code path, is to read in
any newer rgrps added by gfs2_grow. But since this is a delete operation
it won't actually use any of those new rgrps. It can really only twiddle
the bits from "Unlinked" to "Free" in an existing rgrp. Therefore the
error should not prevent the transition from unlinked to free.
This patch makes gfs2_dinode_dealloc ignore the bad return code and
proceed with freeing the dinode so the QE tests will not be tripped up.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Diffstat (limited to 'fs/gfs2')
| -rw-r--r-- | fs/gfs2/super.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index a84bf6444bba..925bd80d2625 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c @@ -1131,9 +1131,7 @@ static int gfs2_dinode_dealloc(struct gfs2_inode *ip) return -EIO; } - error = gfs2_rindex_update(sdp); - if (error) - return error; + gfs2_rindex_update(sdp); error = gfs2_quota_hold(ip, NO_UID_QUOTA_CHANGE, NO_GID_QUOTA_CHANGE); if (error) |