diff options
author | Kari Argillander <kari.argillander@gmail.com> | 2021-08-24 21:37:07 +0300 |
---|---|---|
committer | Konstantin Komarov <almaz.alexandrovich@paragon-software.com> | 2021-08-27 17:05:12 +0300 |
commit | 195c52bdd5d5ecfdabf5a7c6159efe299e534f84 (patch) | |
tree | 19b4150df32241152b7b8233aa7099e1e7a794c5 /fs/ntfs3/run.c | |
parent | fa3cacf544636b2dc48cfb2f277a2071f14d66a2 (diff) |
fs/ntfs3: Do not use driver own alloc wrappers
Problem with these wrapper is that we cannot take off example GFP_NOFS
flag. It is not recomended use those in all places. Also if we change
one driver specific wrapper to kernel wrapper then it would look really
weird. People should be most familiar with kernel wrappers so let's just
use those ones.
Driver specific alloc wrapper also confuse some static analyzing tools,
good example is example kernels checkpatch tool. After we converter
these to kernel specific then warnings is showed.
Following Coccinelle script was used to automate changing.
virtual patch
@alloc depends on patch@
expression x;
expression y;
@@
(
- ntfs_malloc(x)
+ kmalloc(x, GFP_NOFS)
|
- ntfs_zalloc(x)
+ kzalloc(x, GFP_NOFS)
|
- ntfs_vmalloc(x)
+ kvmalloc(x, GFP_NOFS)
|
- ntfs_free(x)
+ kfree(x)
|
- ntfs_vfree(x)
+ kvfree(x)
|
- ntfs_memdup(x, y)
+ kmemdup(x, y, GFP_NOFS)
)
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Kari Argillander <kari.argillander@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Diffstat (limited to 'fs/ntfs3/run.c')
-rw-r--r-- | fs/ntfs3/run.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/ntfs3/run.c b/fs/ntfs3/run.c index 60c64deab738..a9989f7536ba 100644 --- a/fs/ntfs3/run.c +++ b/fs/ntfs3/run.c @@ -254,7 +254,7 @@ void run_truncate_head(struct runs_tree *run, CLST vcn) run->count -= index; if (!run->count) { - ntfs_vfree(run->runs); + kvfree(run->runs); run->runs = NULL; run->allocated = 0; } @@ -293,7 +293,7 @@ void run_truncate(struct runs_tree *run, CLST vcn) /* Do not reallocate array 'runs'. Only free if possible */ if (!index) { - ntfs_vfree(run->runs); + kvfree(run->runs); run->runs = NULL; run->allocated = 0; } @@ -388,7 +388,7 @@ requires_new_range: WARN_ON(!is_mft && bytes > NTFS3_RUN_MAX_BYTES); - new_ptr = ntfs_vmalloc(bytes); + new_ptr = kvmalloc(bytes, GFP_KERNEL); if (!new_ptr) return false; @@ -399,7 +399,7 @@ requires_new_range: memcpy(r + 1, run->runs + index, sizeof(struct ntfs_run) * (run->count - index)); - ntfs_vfree(run->runs); + kvfree(run->runs); run->runs = new_ptr; run->allocated = bytes; |