diff options
| author | Namjae Jeon <linkinjeon@kernel.org> | 2024-11-04 13:40:41 +0900 |
|---|---|---|
| committer | Namjae Jeon <linkinjeon@kernel.org> | 2024-11-05 09:26:37 +0900 |
| commit | b8fc56fbca7482c1e5c0e3351c6ae78982e25ada (patch) | |
| tree | 880494e0b32e22eb3592d14bd9cccab4ed8f2e80 /fs/smb | |
| parent | 0a77715db22611df50b178374c51e2ba0d58866e (diff) | |
ksmbd: fix slab-use-after-free in smb3_preauth_hash_rsp
ksmbd_user_session_put should be called under smb3_preauth_hash_rsp().
It will avoid freeing session before calling smb3_preauth_hash_rsp().
Cc: stable@vger.kernel.org # v5.15+
Reported-by: Norbert Szetei <norbert@doyensec.com>
Tested-by: Norbert Szetei <norbert@doyensec.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/smb')
| -rw-r--r-- | fs/smb/server/server.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/smb/server/server.c b/fs/smb/server/server.c index 9670c97f14b3..e7f14f8df943 100644 --- a/fs/smb/server/server.c +++ b/fs/smb/server/server.c @@ -238,11 +238,11 @@ static void __handle_ksmbd_work(struct ksmbd_work *work, } while (is_chained == true); send: - if (work->sess) - ksmbd_user_session_put(work->sess); if (work->tcon) ksmbd_tree_connect_put(work->tcon); smb3_preauth_hash_rsp(work); + if (work->sess) + ksmbd_user_session_put(work->sess); if (work->sess && work->sess->enc && work->encrypted && conn->ops->encrypt_resp) { rc = conn->ops->encrypt_resp(work); |