diff options
author | Darrick J. Wong <darrick.wong@oracle.com> | 2018-10-18 17:20:35 +1100 |
---|---|---|
committer | Dave Chinner <david@fromorbit.com> | 2018-10-18 17:20:35 +1100 |
commit | 38b6238eb6b4f4b7fe5442670156c81b21516bee (patch) | |
tree | e1a442af0be3fdc594477db77eeedeb5b857f9fe /fs/xfs/xfs_fsops.c | |
parent | 1aff5696f3e03099a4a3e9a0d965ef9b345265a6 (diff) |
xfs: fix buffer state management in xrep_findroot_block
We don't handle buffer state properly in online repair's findroot
routine. If a buffer already has b_ops set, we don't ever want to touch
that, and we don't want to call the read verifiers on a buffer that
could be dirty (CRCs are only recomputed during log checkpoints).
Therefore, be more careful about what we do with a buffer -- if someone
else already attached ops that are not the ones for this btree type,
just ignore the buffer. We only attach our btree type's buf ops if it
matches the magic/uuid and structure checks.
We also modify xfs_buf_read_map to allow callers to set buffer ops on a
DONE buffer with NULL ops so that repair doesn't leave behind buffers
which won't have buffers attached to them.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs/xfs/xfs_fsops.c')
0 files changed, 0 insertions, 0 deletions