diff options
| author | Christoph Hellwig <hch@lst.de> | 2022-12-21 10:30:45 +0100 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2022-12-28 06:25:55 -1000 |
| commit | 685e6311637e46f3212439ce2789f8a300e5050f (patch) | |
| tree | 730a5ae32ea43ae01effa1fc6351265b2f4d2eee /include/linux | |
| parent | 8ca4fc323d2e4ab9dabbdd57633af40b0c7e6af9 (diff) | |
nvme: fix the NVME_CMD_EFFECTS_CSE_MASK definition
3 << 16 does not generate the correct mask for bits 16, 17 and 18.
Use the GENMASK macro to generate the correct mask instead.
Fixes: 84fef62d135b ("nvme: check admin passthru command effects")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/nvme.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/linux/nvme.h b/include/linux/nvme.h index d6be2a686100..d1cd53f2b6ab 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -7,6 +7,7 @@ #ifndef _LINUX_NVME_H #define _LINUX_NVME_H +#include <linux/bits.h> #include <linux/types.h> #include <linux/uuid.h> @@ -639,7 +640,7 @@ enum { NVME_CMD_EFFECTS_NCC = 1 << 2, NVME_CMD_EFFECTS_NIC = 1 << 3, NVME_CMD_EFFECTS_CCC = 1 << 4, - NVME_CMD_EFFECTS_CSE_MASK = 3 << 16, + NVME_CMD_EFFECTS_CSE_MASK = GENMASK(18, 16), NVME_CMD_EFFECTS_UUID_SEL = 1 << 19, }; |