summaryrefslogtreecommitdiff
path: root/init
diff options
context:
space:
mode:
authorWillem de Bruijn <willemb@google.com>2021-01-09 17:18:34 -0500
committerJakub Kicinski <kuba@kernel.org>2021-01-11 18:20:09 -0800
commit9bd6b629c39e3fa9e14243a6d8820492be1a5b2e (patch)
treea5a886f486cb705d9e421bf20b742950b7cf8191 /init
parent97550f6fa59254435d864b92603de3ca4b5a99f8 (diff)
esp: avoid unneeded kmap_atomic call
esp(6)_output_head uses skb_page_frag_refill to allocate a buffer for the esp trailer. It accesses the page with kmap_atomic to handle highmem. But skb_page_frag_refill can return compound pages, of which kmap_atomic only maps the first underlying page. skb_page_frag_refill does not return highmem, because flag __GFP_HIGHMEM is not set. ESP uses it in the same manner as TCP. That also does not call kmap_atomic, but directly uses page_address, in skb_copy_to_page_nocache. Do the same for ESP. This issue has become easier to trigger with recent kmap local debugging feature CONFIG_DEBUG_KMAP_LOCAL_FORCE_MAP. Fixes: cac2661c53f3 ("esp4: Avoid skb_cow_data whenever possible") Fixes: 03e2a30f6a27 ("esp6: Avoid skb_cow_data whenever possible") Signed-off-by: Willem de Bruijn <willemb@google.com> Acked-by: Steffen Klassert <steffen.klassert@secunet.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions