diff options
| author | Tejun Heo <tj@kernel.org> | 2024-10-02 10:34:38 -1000 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2024-10-04 10:12:11 -1000 |
| commit | ec010333ce7cf3270ae7193a6724794d5a179625 (patch) | |
| tree | bd126fecadfff9cd0197b67a89307a5fb12a02f4 /kernel/sched | |
| parent | cc9877fb76771b7cbce6c9ec239f13a1d7759876 (diff) | |
sched_ext: scx_cgroup_exit() may be called without successful scx_cgroup_init()
568894edbe48 ("sched_ext: Add scx_cgroup_enabled to gate cgroup operations
and fix scx_tg_online()") assumed that scx_cgroup_exit() is only called
after scx_cgroup_init() finished successfully. This isn't true.
scx_cgroup_exit() can be called without scx_cgroup_init() being called at
all or after scx_cgroup_init() failed in the middle.
As init state is tracked per cgroup, scx_cgroup_exit() can be used safely to
clean up in all cases. Remove the incorrect WARN_ON_ONCE().
Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: 568894edbe48 ("sched_ext: Add scx_cgroup_enabled to gate cgroup operations and fix scx_tg_online()")
Diffstat (limited to 'kernel/sched')
| -rw-r--r-- | kernel/sched/ext.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index 76f04f3ace61..1df2082d1352 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -4052,7 +4052,6 @@ static void scx_cgroup_exit(void) percpu_rwsem_assert_held(&scx_cgroup_rwsem); - WARN_ON_ONCE(!scx_cgroup_enabled); scx_cgroup_enabled = false; /* |