diff options
| author | Eric W. Biederman <ebiederm@xmission.com> | 2021-10-08 12:12:56 -0500 |
|---|---|---|
| committer | Eric W. Biederman <ebiederm@xmission.com> | 2021-10-08 12:12:56 -0500 |
| commit | 3f66f86bfed33dee2e9c1d0e14486915bb0750b0 (patch) | |
| tree | 55800c054b48245841afec2f62605d0ef8990dd6 /mm/debug.c | |
| parent | 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f (diff) | |
| parent | 0258b5fd7c7124b87e185a1a9322d2c66b1876b7 (diff) | |
per signal_struct coredumps
Current coredumps are mixed up with the exit code, the signal handling
code and with the ptrace code in was they are much more complicated than
necessary and difficult to follow.
This series of changes starts with ptrace_stop and cleans it up,
making it easier to follow what is happening in ptrace_stop.
Then cleans up the exec interactions with coredumps.
Then cleans up the coredump interactions with exit.
Then the coredump interactions with the signal handling code is clean
up.
The first and last changes are bug fixes for minor bugs.
I believe the fact that vfork followed by execve can kill the process
the called vfork if exec fails is sufficient justification to change
the userspace visible behavior.
In previous conversations it was suggested that some of these cleanups
did not stand on their own. I think I have managed to organize things
so all of their patches stand on their own.
Which means that if for some reason the last change needs to be reverted
we can still keep the gains from the other changes.
Eric W. Biederman (6):
signal: Remove the bogus sigkill_pending in ptrace_stop
ptrace: Remove the unnecessary arguments from arch_ptrace_stop
exec: Check for a pending fatal signal instead of core_state
exit: Factor coredump_exit_mm out of exit_mm
coredump: Don't perform any cleanups before dumping core
coredump: Limit coredumps to a single thread group
arch/ia64/include/asm/ptrace.h | 4 +-
arch/sparc/include/asm/ptrace.h | 8 ++--
fs/binfmt_elf.c | 4 +-
fs/binfmt_elf_fdpic.c | 2 +-
fs/coredump.c | 88 ++++++-----------------------------------
fs/exec.c | 14 +++----
fs/proc/array.c | 6 +--
include/linux/mm_types.h | 13 ------
include/linux/ptrace.h | 22 +++++------
include/linux/sched.h | 1 +
include/linux/sched/signal.h | 13 ++++++
kernel/exit.c | 76 +++++++++++++++++++----------------
kernel/fork.c | 4 +-
kernel/signal.c | 49 ++++-------------------
mm/debug.c | 4 +-
mm/oom_kill.c | 6 +--
16 files changed, 106 insertions(+), 208 deletions(-)
Link: https://lkml.kernel.org/r/87v92qx2c6.fsf@disp2133
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'mm/debug.c')
| -rw-r--r-- | mm/debug.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mm/debug.c b/mm/debug.c index e73fe0a8ec3d..aa5fe4d5c4b4 100644 --- a/mm/debug.c +++ b/mm/debug.c @@ -214,7 +214,7 @@ void dump_mm(const struct mm_struct *mm) "start_code %lx end_code %lx start_data %lx end_data %lx\n" "start_brk %lx brk %lx start_stack %lx\n" "arg_start %lx arg_end %lx env_start %lx env_end %lx\n" - "binfmt %px flags %lx core_state %px\n" + "binfmt %px flags %lx\n" #ifdef CONFIG_AIO "ioctx_table %px\n" #endif @@ -246,7 +246,7 @@ void dump_mm(const struct mm_struct *mm) mm->start_code, mm->end_code, mm->start_data, mm->end_data, mm->start_brk, mm->brk, mm->start_stack, mm->arg_start, mm->arg_end, mm->env_start, mm->env_end, - mm->binfmt, mm->flags, mm->core_state, + mm->binfmt, mm->flags, #ifdef CONFIG_AIO mm->ioctx_table, #endif |