diff options
author | WANG Cong <xiyou.wangcong@gmail.com> | 2017-06-13 13:36:24 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-06-14 14:39:19 -0400 |
commit | 74030603dfd9f76c0f279f19f1dd1ee3028fee7a (patch) | |
tree | 27b6e967e99232169cadc0420099717f241a38f3 /net/mpls/internal.h | |
parent | 20a3d5bf5e5b13c02450ab6178ec374abd830686 (diff) |
net_sched: move tcf_lock down after gen_replace_estimator()
Laura reported a sleep-in-atomic kernel warning inside
tcf_act_police_init() which calls gen_replace_estimator() with
spinlock protection.
It is not necessary in this case, we already have RTNL lock here
so it is enough to protect concurrent writers. For the reader,
i.e. tcf_act_police(), it needs to make decision based on this
rate estimator, in the worst case we drop more/less packets than
necessary while changing the rate in parallel, it is still acceptable.
Reported-by: Laura Abbott <labbott@redhat.com>
Reported-by: Nick Huber <nicholashuber@gmail.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/mpls/internal.h')
0 files changed, 0 insertions, 0 deletions