summaryrefslogtreecommitdiff
path: root/net/unix
diff options
context:
space:
mode:
authorJakub Kicinski <kuba@kernel.org>2023-08-09 15:27:52 -0700
committerJakub Kicinski <kuba@kernel.org>2023-08-09 15:27:53 -0700
commit7654c109692521b0e1e582a37077b94f39c64beb (patch)
tree74b9c171737cd8ca325f74b623b5e81c5c9aec1c /net/unix
parentb77049f04ed16cb0ab89b1cca689cd16a3071fd2 (diff)
parentaae5bb8d18d8ca00d658720710a490eebaf9087d (diff)
Merge branch 'mlxsw-set-port-stp-state-on-bridge-enslavement'
Petr Machata says: ==================== mlxsw: Set port STP state on bridge enslavement When the first port joins a LAG that already has a bridge upper, an instance of struct mlxsw_sp_bridge_port is created for the LAG to keep track of it as a bridge port. The bridge_port's STP state is initialized to BR_STATE_DISABLED. This made sense previously, because mlxsw would only ever allow a port to join a LAG if the LAG had no uppers. Thus if a bridge_port was instantiated, it must have been because the LAG as such is joining a bridge, and the STP state is correspondingly disabled. However as of commit 2c5ffe8d7226 ("mlxsw: spectrum: Permit enslavement to netdevices with uppers"), mlxsw allows a port to join a LAG that is already a member of a bridge. The STP state may be different than disabled in that case. Initialize it properly by querying the actual state. This bug may cause an issue as traffic on ports attached to a bridged LAG gets dropped on ingress with discard_ingress_general counter bumped. The above fix in patch #1. Patch #2 contains a selftest that would sporadically reproduce the issue. ==================== Link: https://lore.kernel.org/r/cover.1691498735.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/unix')
0 files changed, 0 insertions, 0 deletions