diff options
author | Andy Lutomirski <luto@kernel.org> | 2022-02-14 13:05:49 +0100 |
---|---|---|
committer | Borislav Petkov <bp@suse.de> | 2022-02-18 11:23:21 +0100 |
commit | 44cad52cc14ae10062f142ec16ede489bccf4469 (patch) | |
tree | d2a0c3287e9e54c622e3f79c74ce7ea900005483 /net/xfrm | |
parent | e5733d8c89c3b57c8fcd40b8acf508388fabaa42 (diff) |
x86/ptrace: Fix xfpregs_set()'s incorrect xmm clearing
xfpregs_set() handles 32-bit REGSET_XFP and 64-bit REGSET_FP. The actual
code treats these regsets as modern FX state (i.e. the beginning part of
XSTATE). The declarations of the regsets thought they were the legacy
i387 format. The code thought they were the 32-bit (no xmm8..15) variant
of XSTATE and, for good measure, made the high bits disappear by zeroing
the wrong part of the buffer. The latter broke ptrace, and everything
else confused anyone trying to understand the code. In particular, the
nonsense definitions of the regsets confused me when I wrote this code.
Clean this all up. Change the declarations to match reality (which
shouldn't change the generated code, let alone the ABI) and fix
xfpregs_set() to clear the correct bits and to only do so for 32-bit
callers.
Fixes: 6164331d15f7 ("x86/fpu: Rewrite xfpregs_set()")
Reported-by: Luís Ferreira <contact@lsferreira.net>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: <stable@vger.kernel.org>
Link: https://bugzilla.kernel.org/show_bug.cgi?id=215524
Link: https://lore.kernel.org/r/YgpFnZpF01WwR8wU@zn.tnic
Diffstat (limited to 'net/xfrm')
0 files changed, 0 insertions, 0 deletions