diff options
author | Arun Ramadoss <arun.ramadoss@microchip.com> | 2021-10-11 21:18:08 +0530 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2021-10-12 11:35:53 +0100 |
commit | ef1100ef20f29aec4e62abeccdb5bdbebba1e378 (patch) | |
tree | e67de351a71dd3f823671bb89777399759b7a6f9 /net | |
parent | 9973a43012b6ad1720dbc4d5faf5302c28635b8c (diff) |
net: dsa: microchip: Added the condition for scheduling ksz_mib_read_work
When the ksz module is installed and removed using rmmod, kernel crashes
with null pointer dereferrence error. During rmmod, ksz_switch_remove
function tries to cancel the mib_read_workqueue using
cancel_delayed_work_sync routine and unregister switch from dsa.
During dsa_unregister_switch it calls ksz_mac_link_down, which in turn
reschedules the workqueue since mib_interval is non-zero.
Due to which queue executed after mib_interval and it tries to access
dp->slave. But the slave is unregistered in the ksz_switch_remove
function. Hence kernel crashes.
To avoid this crash, before canceling the workqueue, resetted the
mib_interval to 0.
v1 -> v2:
-Removed the if condition in ksz_mib_read_work
Fixes: 469b390e1ba3 ("net: dsa: microchip: use delayed_work instead of timer + work")
Signed-off-by: Arun Ramadoss <arun.ramadoss@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions