diff options
author | Oleksij Rempel <o.rempel@pengutronix.de> | 2024-01-24 13:33:14 +0100 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2024-01-26 21:25:25 -0800 |
commit | 9e62bed6e105f2f522e360a024fc93c64c58a207 (patch) | |
tree | 50c21a15c42a2928feef6ee5eafb6a2ea15c5663 /rust | |
parent | d1b7d0d85d59bfe6f57b1604a922466e4f8ee734 (diff) |
net: dsa: microchip: implement PHY loopback configuration for KSZ8794 and KSZ8873
Correct the PHY loopback bit handling in the ksz8_w_phy_bmcr and
ksz8_r_phy_bmcr functions for KSZ8794 and KSZ8873 variants in the ksz8795
driver. Previously, the code erroneously used Bit 7 of port register 0xD
for both chip variants, which is actually for LED configuration. This
update ensures the correct registers and bits are used for the PHY
loopback feature:
- For KSZ8794: Use 0xF / Bit 7.
- For KSZ8873: Use 0xD / Bit 0.
The lack of loopback support was seen on KSZ8873 system by using
"ethtool -t lanX". After this patch, the ethtool selftest will work,
but only if port is not part of a bridge.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
Link: https://lore.kernel.org/r/20240124123314.734815-4-o.rempel@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'rust')
0 files changed, 0 insertions, 0 deletions