diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2020-10-02 15:52:44 -0400 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2020-10-12 10:29:44 -0400 |
| commit | cc028a10a48c3c555d7772d02f56eea9f86fdf79 (patch) | |
| tree | 78c88ccb5662c6f189f33abbb33c636456e61d3f /scripts | |
| parent | 4b74fd793a77f6149d68dbf95574311af9506e39 (diff) | |
NFSD: Hoist status code encoding into XDR encoder functions
The original intent was presumably to reduce code duplication. The
trade-off was:
- No support for an NFSD proc function returning a non-success
RPC accept_stat value.
- No support for void NFS replies to non-NULL procedures.
- Everyone pays for the deduplication with a few extra conditional
branches in a hot path.
In addition, nfsd_dispatch() leaves *statp uninitialized in the
success path, unlike svc_generic_dispatch().
Address all of these problems by moving the logic for encoding
the NFS status code into the NFS XDR encoders themselves. Then
update the NFS .pc_func methods to return an RPC accept_stat
value.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions