diff options
| author | Takashi Iwai <tiwai@suse.de> | 2021-06-08 16:05:13 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2021-06-09 17:30:08 +0200 |
| commit | 549717fc5b4cf5a791d46e23c607c03afc8c94d3 (patch) | |
| tree | 2ab21caba25347d3d34969b2398e1b630733ea14 /sound/pci/echoaudio/echoaudio_gml.c | |
| parent | 164b3ddeb026bf86df1829577674ed506ff4cbde (diff) | |
ALSA: echoaudio: Fix assignment in if condition
PCI echoaudio drivers contain a few assignments in if condition, which
is a bad coding style that may confuse readers and occasionally lead
to bugs.
This patch is merely for coding-style fixes, no functional changes.
Link: https://lore.kernel.org/r/20210608140540.17885-40-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/echoaudio/echoaudio_gml.c')
| -rw-r--r-- | sound/pci/echoaudio/echoaudio_gml.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/pci/echoaudio/echoaudio_gml.c b/sound/pci/echoaudio/echoaudio_gml.c index eea6fe530ab4..248983fa2959 100644 --- a/sound/pci/echoaudio/echoaudio_gml.c +++ b/sound/pci/echoaudio/echoaudio_gml.c @@ -194,7 +194,8 @@ static int set_professional_spdif(struct echoaudio *chip, char prof) } } - if ((err = write_control_reg(chip, control_reg, false))) + err = write_control_reg(chip, control_reg, false); + if (err) return err; chip->professional_spdif = prof; dev_dbg(chip->card->dev, "set_professional_spdif to %s\n", |