diff options
| author | Peter Zijlstra <peterz@infradead.org> | 2020-03-10 18:39:45 +0100 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2020-03-25 18:28:28 +0100 |
| commit | 65fb11a7f6aeae678043738d06248a4e21f4e4e4 (patch) | |
| tree | e0fdb3bbce4da48058fd87271d2375d5ad68e5de /tools/objtool/elf.h | |
| parent | 36cc552055a5f95bab479533b4ebbad6a6cea0e1 (diff) | |
objtool: Optimize find_symbol_by_index()
The symbol index is object wide, not per section, so it makes no sense
to have the symbol_hash be part of the section object. By moving it to
the elf object we avoid the linear sections iteration.
This reduces the runtime of objtool on vmlinux.o from over 3 hours (I
gave up) to a few minutes. The defconfig vmlinux.o has around 20k
sections.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Link: https://lkml.kernel.org/r/20200324160924.261852348@infradead.org
Diffstat (limited to 'tools/objtool/elf.h')
| -rw-r--r-- | tools/objtool/elf.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tools/objtool/elf.h b/tools/objtool/elf.h index a1963259b930..12229801b13f 100644 --- a/tools/objtool/elf.h +++ b/tools/objtool/elf.h @@ -27,7 +27,6 @@ struct section { struct list_head list; GElf_Shdr sh; struct list_head symbol_list; - DECLARE_HASHTABLE(symbol_hash, 8); struct list_head rela_list; DECLARE_HASHTABLE(rela_hash, 16); struct section *base, *rela; @@ -71,7 +70,7 @@ struct elf { int fd; char *name; struct list_head sections; - DECLARE_HASHTABLE(rela_hash, 16); + DECLARE_HASHTABLE(symbol_hash, 20); }; |