diff options
Diffstat (limited to 'tools/net/ynl')
| -rwxr-xr-x | tools/net/ynl/ethtool.py | 424 | ||||
| -rw-r--r-- | tools/net/ynl/lib/nlspec.py | 91 | ||||
| -rw-r--r-- | tools/net/ynl/lib/ynl.py | 120 | ||||
| -rw-r--r-- | tools/net/ynl/requirements.txt | 2 | ||||
| -rwxr-xr-x | tools/net/ynl/ynl-gen-c.py | 7 | 
5 files changed, 610 insertions, 34 deletions
| diff --git a/tools/net/ynl/ethtool.py b/tools/net/ynl/ethtool.py new file mode 100755 index 000000000000..6c9f7e31250c --- /dev/null +++ b/tools/net/ynl/ethtool.py @@ -0,0 +1,424 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause + +import argparse +import json +import pprint +import sys +import re + +from lib import YnlFamily + +def args_to_req(ynl, op_name, args, req): +    """ +    Verify and convert command-line arguments to the ynl-compatible request. +    """ +    valid_attrs = ynl.operation_do_attributes(op_name) +    valid_attrs.remove('header') # not user-provided + +    if len(args) == 0: +        print(f'no attributes, expected: {valid_attrs}') +        sys.exit(1) + +    i = 0 +    while i < len(args): +        attr = args[i] +        if i + 1 >= len(args): +            print(f'expected value for \'{attr}\'') +            sys.exit(1) + +        if attr not in valid_attrs: +            print(f'invalid attribute \'{attr}\', expected: {valid_attrs}') +            sys.exit(1) + +        val = args[i+1] +        i += 2 + +        req[attr] = val + +def print_field(reply, *desc): +    """ +    Pretty-print a set of fields from the reply. desc specifies the +    fields and the optional type (bool/yn). +    """ +    if len(desc) == 0: +        return print_field(reply, *zip(reply.keys(), reply.keys())) + +    for spec in desc: +        try: +            field, name, tp = spec +        except: +            field, name = spec +            tp = 'int' + +        value = reply.get(field, None) +        if tp == 'yn': +            value = 'yes' if value else 'no' +        elif tp == 'bool' or isinstance(value, bool): +            value = 'on' if value else 'off' +        else: +            value = 'n/a' if value is None else value + +        print(f'{name}: {value}') + +def print_speed(name, value): +    """ +    Print out the speed-like strings from the value dict. +    """ +    speed_re = re.compile(r'[0-9]+base[^/]+/.+') +    speed = [ k for k, v in value.items() if v and speed_re.match(k) ] +    print(f'{name}: {" ".join(speed)}') + +def doit(ynl, args, op_name): +    """ +    Prepare request header, parse arguments and doit. +    """ +    req = { +        'header': { +          'dev-name': args.device, +        }, +    } + +    args_to_req(ynl, op_name, args.args, req) +    ynl.do(op_name, req) + +def dumpit(ynl, args, op_name, extra = {}): +    """ +    Prepare request header, parse arguments and dumpit (filtering out the +    devices we're not interested in). +    """ +    reply = ynl.dump(op_name, { 'header': {} } | extra) +    if not reply: +        return {} + +    for msg in reply: +        if msg['header']['dev-name'] == args.device: +            if args.json: +                pprint.PrettyPrinter().pprint(msg) +                sys.exit(0) +            msg.pop('header', None) +            return msg + +    print(f"Not supported for device {args.device}") +    sys.exit(1) + +def bits_to_dict(attr): +    """ +    Convert ynl-formatted bitmask to a dict of bit=value. +    """ +    ret = {} +    if 'bits' not in attr: +        return dict() +    if 'bit' not in attr['bits']: +        return dict() +    for bit in attr['bits']['bit']: +        if bit['name'] == '': +            continue +        name = bit['name'] +        value = bit.get('value', False) +        ret[name] = value +    return ret + +def main(): +    parser = argparse.ArgumentParser(description='ethtool wannabe') +    parser.add_argument('--json', action=argparse.BooleanOptionalAction) +    parser.add_argument('--show-priv-flags', action=argparse.BooleanOptionalAction) +    parser.add_argument('--set-priv-flags', action=argparse.BooleanOptionalAction) +    parser.add_argument('--show-eee', action=argparse.BooleanOptionalAction) +    parser.add_argument('--set-eee', action=argparse.BooleanOptionalAction) +    parser.add_argument('-a', '--show-pause', action=argparse.BooleanOptionalAction) +    parser.add_argument('-A', '--set-pause', action=argparse.BooleanOptionalAction) +    parser.add_argument('-c', '--show-coalesce', action=argparse.BooleanOptionalAction) +    parser.add_argument('-C', '--set-coalesce', action=argparse.BooleanOptionalAction) +    parser.add_argument('-g', '--show-ring', action=argparse.BooleanOptionalAction) +    parser.add_argument('-G', '--set-ring', action=argparse.BooleanOptionalAction) +    parser.add_argument('-k', '--show-features', action=argparse.BooleanOptionalAction) +    parser.add_argument('-K', '--set-features', action=argparse.BooleanOptionalAction) +    parser.add_argument('-l', '--show-channels', action=argparse.BooleanOptionalAction) +    parser.add_argument('-L', '--set-channels', action=argparse.BooleanOptionalAction) +    parser.add_argument('-T', '--show-time-stamping', action=argparse.BooleanOptionalAction) +    parser.add_argument('-S', '--statistics', action=argparse.BooleanOptionalAction) +    # TODO: --show-tunnels        tunnel-info-get +    # TODO: --show-module         module-get +    # TODO: --get-plca-cfg        plca-get +    # TODO: --get-plca-status     plca-get-status +    # TODO: --show-mm             mm-get +    # TODO: --show-fec            fec-get +    # TODO: --dump-module-eerpom  module-eeprom-get +    # TODO:                       pse-get +    # TODO:                       rss-get +    parser.add_argument('device', metavar='device', type=str) +    parser.add_argument('args', metavar='args', type=str, nargs='*') +    global args +    args = parser.parse_args() + +    spec = '../../../Documentation/netlink/specs/ethtool.yaml' +    schema = '../../../Documentation/netlink/genetlink-legacy.yaml' + +    ynl = YnlFamily(spec, schema) + +    if args.set_priv_flags: +        # TODO: parse the bitmask +        print("not implemented") +        return + +    if args.set_eee: +        return doit(ynl, args, 'eee-set') + +    if args.set_pause: +        return doit(ynl, args, 'pause-set') + +    if args.set_coalesce: +        return doit(ynl, args, 'coalesce-set') + +    if args.set_features: +        # TODO: parse the bitmask +        print("not implemented") +        return + +    if args.set_channels: +        return doit(ynl, args, 'channels-set') + +    if args.set_ring: +        return doit(ynl, args, 'rings-set') + +    if args.show_priv_flags: +        flags = bits_to_dict(dumpit(ynl, args, 'privflags-get')['flags']) +        print_field(flags) +        return + +    if args.show_eee: +        eee = dumpit(ynl, args, 'eee-get') +        ours = bits_to_dict(eee['modes-ours']) +        peer = bits_to_dict(eee['modes-peer']) + +        if 'enabled' in eee: +            status = 'enabled' if eee['enabled'] else 'disabled' +            if 'active' in eee and eee['active']: +                status = status + ' - active' +            else: +                status = status + ' - inactive' +        else: +            status = 'not supported' + +        print(f'EEE status: {status}') +        print_field(eee, ('tx-lpi-timer', 'Tx LPI')) +        print_speed('Advertised EEE link modes', ours) +        print_speed('Link partner advertised EEE link modes', peer) + +        return + +    if args.show_pause: +        print_field(dumpit(ynl, args, 'pause-get'), +                ('autoneg', 'Autonegotiate', 'bool'), +                ('rx', 'RX', 'bool'), +                ('tx', 'TX', 'bool')) +        return + +    if args.show_coalesce: +        print_field(dumpit(ynl, args, 'coalesce-get')) +        return + +    if args.show_features: +        reply = dumpit(ynl, args, 'features-get') +        available = bits_to_dict(reply['hw']) +        requested = bits_to_dict(reply['wanted']).keys() +        active = bits_to_dict(reply['active']).keys() +        never_changed = bits_to_dict(reply['nochange']).keys() + +        for f in sorted(available): +            value = "off" +            if f in active: +                value = "on" + +            fixed = "" +            if f not in available or f in never_changed: +                fixed = " [fixed]" + +            req = "" +            if f in requested: +                if f in active: +                    req = " [requested on]" +                else: +                    req = " [requested off]" + +            print(f'{f}: {value}{fixed}{req}') + +        return + +    if args.show_channels: +        reply = dumpit(ynl, args, 'channels-get') +        print(f'Channel parameters for {args.device}:') + +        print(f'Pre-set maximums:') +        print_field(reply, +            ('rx-max', 'RX'), +            ('tx-max', 'TX'), +            ('other-max', 'Other'), +            ('combined-max', 'Combined')) + +        print(f'Current hardware settings:') +        print_field(reply, +            ('rx-count', 'RX'), +            ('tx-count', 'TX'), +            ('other-count', 'Other'), +            ('combined-count', 'Combined')) + +        return + +    if args.show_ring: +        reply = dumpit(ynl, args, 'channels-get') + +        print(f'Ring parameters for {args.device}:') + +        print(f'Pre-set maximums:') +        print_field(reply, +            ('rx-max', 'RX'), +            ('rx-mini-max', 'RX Mini'), +            ('rx-jumbo-max', 'RX Jumbo'), +            ('tx-max', 'TX')) + +        print(f'Current hardware settings:') +        print_field(reply, +            ('rx', 'RX'), +            ('rx-mini', 'RX Mini'), +            ('rx-jumbo', 'RX Jumbo'), +            ('tx', 'TX')) + +        print_field(reply, +            ('rx-buf-len', 'RX Buf Len'), +            ('cqe-size', 'CQE Size'), +            ('tx-push', 'TX Push', 'bool')) + +        return + +    if args.statistics: +        print(f'NIC statistics:') + +        # TODO: pass id? +        strset = dumpit(ynl, args, 'strset-get') +        pprint.PrettyPrinter().pprint(strset) + +        req = { +          'groups': { +            'size': 1, +            'bits': { +              'bit': +                # TODO: support passing the bitmask +                #[ +                  #{ 'name': 'eth-phy', 'value': True }, +                  { 'name': 'eth-mac', 'value': True }, +                  #{ 'name': 'eth-ctrl', 'value': True }, +                  #{ 'name': 'rmon', 'value': True }, +                #], +            }, +          }, +        } + +        rsp = dumpit(ynl, args, 'stats-get', req) +        pprint.PrettyPrinter().pprint(rsp) +        return + +    if args.show_time_stamping: +        tsinfo = dumpit(ynl, args, 'tsinfo-get') + +        print(f'Time stamping parameters for {args.device}:') + +        print('Capabilities:') +        [print(f'\t{v}') for v in bits_to_dict(tsinfo['timestamping'])] + +        print(f'PTP Hardware Clock: {tsinfo["phc-index"]}') + +        print('Hardware Transmit Timestamp Modes:') +        [print(f'\t{v}') for v in bits_to_dict(tsinfo['tx-types'])] + +        print('Hardware Receive Filter Modes:') +        [print(f'\t{v}') for v in bits_to_dict(tsinfo['rx-filters'])] +        return + +    print(f'Settings for {args.device}:') +    linkmodes = dumpit(ynl, args, 'linkmodes-get') +    ours = bits_to_dict(linkmodes['ours']) + +    supported_ports = ('TP',  'AUI', 'BNC', 'MII', 'FIBRE', 'Backplane') +    ports = [ p for p in supported_ports if ours.get(p, False)] +    print(f'Supported ports: [ {" ".join(ports)} ]') + +    print_speed('Supported link modes', ours) + +    print_field(ours, ('Pause', 'Supported pause frame use', 'yn')) +    print_field(ours, ('Autoneg', 'Supports auto-negotiation', 'yn')) + +    supported_fec = ('None',  'PS', 'BASER', 'LLRS') +    fec = [ p for p in supported_fec if ours.get(p, False)] +    fec_str = " ".join(fec) +    if len(fec) == 0: +        fec_str = "Not reported" + +    print(f'Supported FEC modes: {fec_str}') + +    speed = 'Unknown!' +    if linkmodes['speed'] > 0 and linkmodes['speed'] < 0xffffffff: +        speed = f'{linkmodes["speed"]}Mb/s' +    print(f'Speed: {speed}') + +    duplex_modes = { +            0: 'Half', +            1: 'Full', +    } +    duplex = duplex_modes.get(linkmodes["duplex"], None) +    if not duplex: +        duplex = f'Unknown! ({linkmodes["duplex"]})' +    print(f'Duplex: {duplex}') + +    autoneg = "off" +    if linkmodes.get("autoneg", 0) != 0: +        autoneg = "on" +    print(f'Auto-negotiation: {autoneg}') + +    ports = { +            0: 'Twisted Pair', +            1: 'AUI', +            2: 'MII', +            3: 'FIBRE', +            4: 'BNC', +            5: 'Directly Attached Copper', +            0xef: 'None', +    } +    linkinfo = dumpit(ynl, args, 'linkinfo-get') +    print(f'Port: {ports.get(linkinfo["port"], "Other")}') + +    print_field(linkinfo, ('phyaddr', 'PHYAD')) + +    transceiver = { +            0: 'Internal', +            1: 'External', +    } +    print(f'Transceiver: {transceiver.get(linkinfo["transceiver"], "Unknown")}') + +    mdix_ctrl = { +            1: 'off', +            2: 'on', +    } +    mdix = mdix_ctrl.get(linkinfo['tp-mdix-ctrl'], None) +    if mdix: +        mdix = mdix + ' (forced)' +    else: +        mdix = mdix_ctrl.get(linkinfo['tp-mdix'], 'Unknown (auto)') +    print(f'MDI-X: {mdix}') + +    debug = dumpit(ynl, args, 'debug-get') +    msgmask = bits_to_dict(debug.get("msgmask", [])).keys() +    print(f'Current message level: {" ".join(msgmask)}') + +    linkstate = dumpit(ynl, args, 'linkstate-get') +    detected_states = { +            0: 'no', +            1: 'yes', +    } +    # TODO: wol-get +    detected = detected_states.get(linkstate['link'], 'unknown') +    print(f'Link detected: {detected}') + +if __name__ == '__main__': +    main() diff --git a/tools/net/ynl/lib/nlspec.py b/tools/net/ynl/lib/nlspec.py index d04450c2a44a..a0241add3839 100644 --- a/tools/net/ynl/lib/nlspec.py +++ b/tools/net/ynl/lib/nlspec.py @@ -90,8 +90,8 @@ class SpecEnumEntry(SpecElement):      def raw_value(self):          return self.value -    def user_value(self): -        if self.enum_set['type'] == 'flags': +    def user_value(self, as_flags=None): +        if self.enum_set['type'] == 'flags' or as_flags:              return 1 << self.value          else:              return self.value @@ -136,10 +136,10 @@ class SpecEnumSet(SpecElement):                  return True          return False -    def get_mask(self): +    def get_mask(self, as_flags=None):          mask = 0          for e in self.entries.values(): -            mask += e.user_value() +            mask += e.user_value(as_flags)          return mask @@ -149,8 +149,11 @@ class SpecAttr(SpecElement):      Represents a single attribute type within an attr space.      Attributes: -        value      numerical ID when serialized -        attr_set   Attribute Set containing this attr +        value         numerical ID when serialized +        attr_set      Attribute Set containing this attr +        is_multi      bool, attr may repeat multiple times +        struct_name   string, name of struct definition +        sub_type      string, name of sub type      """      def __init__(self, family, attr_set, yaml, value):          super().__init__(family, yaml) @@ -158,6 +161,9 @@ class SpecAttr(SpecElement):          self.value = value          self.attr_set = attr_set          self.is_multi = yaml.get('multi-attr', False) +        self.struct_name = yaml.get('struct') +        self.sub_type = yaml.get('sub-type') +        self.byte_order = yaml.get('byte-order')  class SpecAttrSet(SpecElement): @@ -214,22 +220,61 @@ class SpecAttrSet(SpecElement):          return self.attrs.items() +class SpecStructMember(SpecElement): +    """Struct member attribute + +    Represents a single struct member attribute. + +    Attributes: +        type    string, type of the member attribute +    """ +    def __init__(self, family, yaml): +        super().__init__(family, yaml) +        self.type = yaml['type'] + + +class SpecStruct(SpecElement): +    """Netlink struct type + +    Represents a C struct definition. + +    Attributes: +        members   ordered list of struct members +    """ +    def __init__(self, family, yaml): +        super().__init__(family, yaml) + +        self.members = [] +        for member in yaml.get('members', []): +            self.members.append(self.new_member(family, member)) + +    def new_member(self, family, elem): +        return SpecStructMember(family, elem) + +    def __iter__(self): +        yield from self.members + +    def items(self): +        return self.members.items() + +  class SpecOperation(SpecElement):      """Netlink Operation      Information about a single Netlink operation.      Attributes: -        value       numerical ID when serialized, None if req/rsp values differ +        value           numerical ID when serialized, None if req/rsp values differ -        req_value   numerical ID when serialized, user -> kernel -        rsp_value   numerical ID when serialized, user <- kernel -        is_call     bool, whether the operation is a call -        is_async    bool, whether the operation is a notification -        is_resv     bool, whether the operation does not exist (it's just a reserved ID) -        attr_set    attribute set name +        req_value       numerical ID when serialized, user -> kernel +        rsp_value       numerical ID when serialized, user <- kernel +        is_call         bool, whether the operation is a call +        is_async        bool, whether the operation is a notification +        is_resv         bool, whether the operation does not exist (it's just a reserved ID) +        attr_set        attribute set name +        fixed_header    string, optional name of fixed header struct -        yaml        raw spec as loaded from the spec file +        yaml            raw spec as loaded from the spec file      """      def __init__(self, family, yaml, req_value, rsp_value):          super().__init__(family, yaml) @@ -241,6 +286,7 @@ class SpecOperation(SpecElement):          self.is_call = 'do' in yaml or 'dump' in yaml          self.is_async = 'notify' in yaml or 'event' in yaml          self.is_resv = not self.is_async and not self.is_call +        self.fixed_header = self.yaml.get('fixed-header', family.fixed_header)          # Added by resolve:          self.attr_set = None @@ -281,6 +327,7 @@ class SpecFamily(SpecElement):          msgs_by_value  dict of all messages (indexed by name)          ops        dict of all valid requests / responses          consts     dict of all constants/enums +        fixed_header  string, optional name of family default fixed header struct      """      def __init__(self, spec_path, schema_path=None):          with open(spec_path, "r") as stream: @@ -344,6 +391,9 @@ class SpecFamily(SpecElement):      def new_attr_set(self, elem):          return SpecAttrSet(self, elem) +    def new_struct(self, elem): +        return SpecStruct(self, elem) +      def new_operation(self, elem, req_val, rsp_val):          return SpecOperation(self, elem, req_val, rsp_val) @@ -351,6 +401,7 @@ class SpecFamily(SpecElement):          self._resolution_list.append(elem)      def _dictify_ops_unified(self): +        self.fixed_header = self.yaml['operations'].get('fixed-header')          val = 1          for elem in self.yaml['operations']['list']:              if 'value' in elem: @@ -362,6 +413,7 @@ class SpecFamily(SpecElement):              self.msgs[op.name] = op      def _dictify_ops_directional(self): +        self.fixed_header = self.yaml['operations'].get('fixed-header')          req_val = rsp_val = 1          for elem in self.yaml['operations']['list']:              if 'notify' in elem: @@ -392,6 +444,15 @@ class SpecFamily(SpecElement):              self.msgs[op.name] = op +    def find_operation(self, name): +      """ +      For a given operation name, find and return operation spec. +      """ +      for op in self.yaml['operations']['list']: +        if name == op['name']: +          return op +      return None +      def resolve(self):          self.resolve_up(super()) @@ -399,6 +460,8 @@ class SpecFamily(SpecElement):          for elem in definitions:              if elem['type'] == 'enum' or elem['type'] == 'flags':                  self.consts[elem['name']] = self.new_enum(elem) +            elif elem['type'] == 'struct': +                self.consts[elem['name']] = self.new_struct(elem)              else:                  self.consts[elem['name']] = elem diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py index 32536e1f9064..aa77bcae4807 100644 --- a/tools/net/ynl/lib/ynl.py +++ b/tools/net/ynl/lib/ynl.py @@ -67,7 +67,20 @@ class Netlink:      NLMSGERR_ATTR_MISS_NEST = 6 +class NlError(Exception): +  def __init__(self, nl_msg): +    self.nl_msg = nl_msg + +  def __str__(self): +    return f"Netlink error: {os.strerror(-self.nl_msg.error)}\n{self.nl_msg}" + +  class NlAttr: +    type_formats = { 'u8' : ('B', 1), 's8' : ('b', 1), +                     'u16': ('H', 2), 's16': ('h', 2), +                     'u32': ('I', 4), 's32': ('i', 4), +                     'u64': ('Q', 8), 's64': ('q', 8) } +      def __init__(self, raw, offset):          self._len, self._type = struct.unpack("HH", raw[offset:offset + 4])          self.type = self._type & ~Netlink.NLA_TYPE_MASK @@ -75,17 +88,25 @@ class NlAttr:          self.full_len = (self.payload_len + 3) & ~3          self.raw = raw[offset + 4:offset + self.payload_len] +    def format_byte_order(byte_order): +        if byte_order: +            return ">" if byte_order == "big-endian" else "<" +        return "" +      def as_u8(self):          return struct.unpack("B", self.raw)[0] -    def as_u16(self): -        return struct.unpack("H", self.raw)[0] +    def as_u16(self, byte_order=None): +        endian = NlAttr.format_byte_order(byte_order) +        return struct.unpack(f"{endian}H", self.raw)[0] -    def as_u32(self): -        return struct.unpack("I", self.raw)[0] +    def as_u32(self, byte_order=None): +        endian = NlAttr.format_byte_order(byte_order) +        return struct.unpack(f"{endian}I", self.raw)[0] -    def as_u64(self): -        return struct.unpack("Q", self.raw)[0] +    def as_u64(self, byte_order=None): +        endian = NlAttr.format_byte_order(byte_order) +        return struct.unpack(f"{endian}Q", self.raw)[0]      def as_strz(self):          return self.raw.decode('ascii')[:-1] @@ -93,6 +114,21 @@ class NlAttr:      def as_bin(self):          return self.raw +    def as_c_array(self, type): +        format, _ = self.type_formats[type] +        return list({ x[0] for x in struct.iter_unpack(format, self.raw) }) + +    def as_struct(self, members): +        value = dict() +        offset = 0 +        for m in members: +            # TODO: handle non-scalar members +            format, size = self.type_formats[m.type] +            decoded = struct.unpack_from(format, self.raw, offset) +            offset += size +            value[m.name] = decoded[0] +        return value +      def __repr__(self):          return f"[type:{self.type} len:{self._len}] {self.raw}" @@ -258,14 +294,22 @@ def _genl_load_families():  class GenlMsg: -    def __init__(self, nl_msg): +    def __init__(self, nl_msg, fixed_header_members=[]):          self.nl = nl_msg          self.hdr = nl_msg.raw[0:4] -        self.raw = nl_msg.raw[4:] +        offset = 4          self.genl_cmd, self.genl_version, _ = struct.unpack("BBH", self.hdr) +        self.fixed_header_attrs = dict() +        for m in fixed_header_members: +            format, size = NlAttr.type_formats[m.type] +            decoded = struct.unpack_from(format, nl_msg.raw, offset) +            offset += size +            self.fixed_header_attrs[m.name] = decoded[0] + +        self.raw = nl_msg.raw[offset:]          self.raw_attrs = NlAttrs(self.raw)      def __repr__(self): @@ -314,7 +358,10 @@ class YnlFamily(SpecFamily):              bound_f = functools.partial(self._op, op_name)              setattr(self, op.ident_name, bound_f) -        self.family = GenlFamily(self.yaml['name']) +        try: +            self.family = GenlFamily(self.yaml['name']) +        except KeyError: +            raise Exception(f"Family '{self.yaml['name']}' not supported by the kernel")      def ntf_subscribe(self, mcast_name):          if mcast_name not in self.family.genl_family['mcast']: @@ -334,8 +381,17 @@ class YnlFamily(SpecFamily):                  attr_payload += self._add_attr(attr['nested-attributes'], subname, subvalue)          elif attr["type"] == 'flag':              attr_payload = b'' +        elif attr["type"] == 'u8': +            attr_payload = struct.pack("B", int(value)) +        elif attr["type"] == 'u16': +            endian = NlAttr.format_byte_order(attr.byte_order) +            attr_payload = struct.pack(f"{endian}H", int(value))          elif attr["type"] == 'u32': -            attr_payload = struct.pack("I", int(value)) +            endian = NlAttr.format_byte_order(attr.byte_order) +            attr_payload = struct.pack(f"{endian}I", int(value)) +        elif attr["type"] == 'u64': +            endian = NlAttr.format_byte_order(attr.byte_order) +            attr_payload = struct.pack(f"{endian}Q", int(value))          elif attr["type"] == 'string':              attr_payload = str(value).encode('ascii') + b'\x00'          elif attr["type"] == 'binary': @@ -361,6 +417,15 @@ class YnlFamily(SpecFamily):              value = enum.entries_by_val[raw - i].name          rsp[attr_spec['name']] = value +    def _decode_binary(self, attr, attr_spec): +        if attr_spec.struct_name: +            decoded = attr.as_struct(self.consts[attr_spec.struct_name]) +        elif attr_spec.sub_type: +            decoded = attr.as_c_array(attr_spec.sub_type) +        else: +            decoded = attr.as_bin() +        return decoded +      def _decode(self, attrs, space):          attr_space = self.attr_sets[space]          rsp = dict() @@ -371,14 +436,16 @@ class YnlFamily(SpecFamily):                  decoded = subdict              elif attr_spec['type'] == 'u8':                  decoded = attr.as_u8() +            elif attr_spec['type'] == 'u16': +                decoded = attr.as_u16(attr_spec.byte_order)              elif attr_spec['type'] == 'u32': -                decoded = attr.as_u32() +                decoded = attr.as_u32(attr_spec.byte_order)              elif attr_spec['type'] == 'u64': -                decoded = attr.as_u64() +                decoded = attr.as_u64(attr_spec.byte_order)              elif attr_spec["type"] == 'string':                  decoded = attr.as_strz()              elif attr_spec["type"] == 'binary': -                decoded = attr.as_bin() +                decoded = self._decode_binary(attr, attr_spec)              elif attr_spec["type"] == 'flag':                  decoded = True              else: @@ -463,6 +530,17 @@ class YnlFamily(SpecFamily):                  self.handle_ntf(nl_msg, gm) +    def operation_do_attributes(self, name): +      """ +      For a given operation name, find and return a supported +      set of attributes (as a dict). +      """ +      op = self.find_operation(name) +      if not op: +        return None + +      return op['do']['request']['attributes'].copy() +      def _op(self, method, vals, dump=False):          op = self.ops[method] @@ -472,6 +550,13 @@ class YnlFamily(SpecFamily):          req_seq = random.randint(1024, 65535)          msg = _genl_msg(self.family.family_id, nl_flags, op.req_value, 1, req_seq) +        fixed_header_members = [] +        if op.fixed_header: +            fixed_header_members = self.consts[op.fixed_header].members +            for m in fixed_header_members: +                value = vals.pop(m.name) +                format, _ = NlAttr.type_formats[m.type] +                msg += struct.pack(format, value)          for name, value in vals.items():              msg += self._add_attr(op.attr_set.name, name, value)          msg = _genl_msg_finalize(msg) @@ -488,9 +573,7 @@ class YnlFamily(SpecFamily):                      self._decode_extack(msg, op.attr_set, nl_msg.extack)                  if nl_msg.error: -                    print("Netlink error:", os.strerror(-nl_msg.error)) -                    print(nl_msg) -                    return +                    raise NlError(nl_msg)                  if nl_msg.done:                      if nl_msg.extack:                          print("Netlink warning:") @@ -498,7 +581,7 @@ class YnlFamily(SpecFamily):                      done = True                      break -                gm = GenlMsg(nl_msg) +                gm = GenlMsg(nl_msg, fixed_header_members)                  # Check if this is a reply to our request                  if nl_msg.nl_seq != req_seq or gm.genl_cmd != op.rsp_value:                      if gm.genl_cmd in self.async_msg_ids: @@ -508,7 +591,8 @@ class YnlFamily(SpecFamily):                          print('Unexpected message: ' + repr(gm))                          continue -                rsp.append(self._decode(gm.raw_attrs, op.attr_set.name)) +                rsp.append(self._decode(gm.raw_attrs, op.attr_set.name) +                           | gm.fixed_header_attrs)          if not rsp:              return None diff --git a/tools/net/ynl/requirements.txt b/tools/net/ynl/requirements.txt new file mode 100644 index 000000000000..0db6ad0c1b39 --- /dev/null +++ b/tools/net/ynl/requirements.txt @@ -0,0 +1,2 @@ +jsonschema==4.* +PyYAML==6.* diff --git a/tools/net/ynl/ynl-gen-c.py b/tools/net/ynl/ynl-gen-c.py index c16671a02621..cc2f8c945340 100755 --- a/tools/net/ynl/ynl-gen-c.py +++ b/tools/net/ynl/ynl-gen-c.py @@ -254,7 +254,8 @@ class TypeScalar(Type):      def _attr_policy(self, policy):          if 'flags-mask' in self.checks or self.is_bitfield:              if self.is_bitfield: -                mask = self.family.consts[self.attr['enum']].get_mask() +                enum = self.family.consts[self.attr['enum']] +                mask = enum.get_mask(as_flags=True)              else:                  flags = self.family.consts[self.checks['flags-mask']]                  flag_cnt = len(flags['entries']) @@ -1696,7 +1697,9 @@ def print_kernel_op_table_fwd(family, cw, terminate):                           'split': 'genl_split_ops'}          struct_type = pol_to_struct[family.kernel_policy] -        if family.kernel_policy == 'split': +        if not exported: +            cnt = "" +        elif family.kernel_policy == 'split':              cnt = 0              for op in family.ops.values():                  if 'do' in op: | 
