From 6f18d7ad9dba48261d34bfd3854d6924eaebb3ef Mon Sep 17 00:00:00 2001 From: Srinivasan Shanmugam Date: Thu, 15 Feb 2024 17:56:55 +0530 Subject: drm/amdgpu: Fix missing parameter descriptions in ih_v7_0.c MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Rectifies kdoc warnings related to the 'ih' parameter in the 'ih_v7_0_get_wptr', 'ih_v7_0_irq_rearm', and 'ih_v7_0_set_rptr' functions within the 'ih_v7_0.c' file. Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/ih_v7_0.c:392: warning: Function parameter or member 'ih' not described in 'ih_v7_0_get_wptr' drivers/gpu/drm/amd/amdgpu/ih_v7_0.c:432: warning: Function parameter or member 'ih' not described in 'ih_v7_0_irq_rearm' drivers/gpu/drm/amd/amdgpu/ih_v7_0.c:458: warning: Function parameter or member 'ih' not described in 'ih_v7_0_set_rptr' Fixes: 12443fc53e7d ("drm/amdgpu: Add ih v7_0 ip block support") Cc: Likun Gao Cc: Hawking Zhang Cc: Christian König Cc: Alex Deucher Signed-off-by: Srinivasan Shanmugam Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/ih_v7_0.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'drivers/gpu/drm/amd/amdgpu/ih_v7_0.c') diff --git a/drivers/gpu/drm/amd/amdgpu/ih_v7_0.c b/drivers/gpu/drm/amd/amdgpu/ih_v7_0.c index 236806797b23..16fe428c0722 100644 --- a/drivers/gpu/drm/amd/amdgpu/ih_v7_0.c +++ b/drivers/gpu/drm/amd/amdgpu/ih_v7_0.c @@ -378,9 +378,10 @@ static void ih_v7_0_irq_disable(struct amdgpu_device *adev) } /** - * ih_v7_0_get_wptr - get the IH ring buffer wptr + * ih_v7_0_get_wptr() - get the IH ring buffer wptr * * @adev: amdgpu_device pointer + * @ih: IH ring buffer to fetch wptr * * Get the IH ring buffer wptr from either the register * or the writeback memory buffer. Also check for @@ -425,6 +426,7 @@ out: * ih_v7_0_irq_rearm - rearm IRQ if lost * * @adev: amdgpu_device pointer + * @ih: IH ring to match * */ static void ih_v7_0_irq_rearm(struct amdgpu_device *adev, @@ -450,8 +452,7 @@ static void ih_v7_0_irq_rearm(struct amdgpu_device *adev, * ih_v7_0_set_rptr - set the IH ring buffer rptr * * @adev: amdgpu_device pointer - * - * Set the IH ring buffer rptr. + * @ih: IH ring buffer to set rptr */ static void ih_v7_0_set_rptr(struct amdgpu_device *adev, struct amdgpu_ih_ring *ih) -- cgit v1.2.3-70-g09d2