From d54cda74a9a27d6a18c6b670f7299114272a5e50 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Tue, 14 Jun 2022 15:08:53 +0300 Subject: drm: logicvc: fix error code in logicvc_layer_init() Return -EINVAL if logicvc_layer_formats_lookup() fails. Don't return success. Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller") Signed-off-by: Dan Carpenter Acked-by: Paul Kocialkowski Signed-off-by: Paul Kocialkowski Link: https://patchwork.freedesktop.org/patch/msgid/Yqh6VdNiDvJYMOQ+@kili --- drivers/gpu/drm/logicvc/logicvc_layer.c | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/gpu/drm/logicvc/logicvc_layer.c') diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c index fbebe966f93a..463653b2c109 100644 --- a/drivers/gpu/drm/logicvc/logicvc_layer.c +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c @@ -491,6 +491,7 @@ static int logicvc_layer_init(struct logicvc_drm *logicvc, if (!formats) { drm_err(drm_dev, "Failed to lookup formats for layer #%d\n", index); + ret = -EINVAL; goto error; } -- cgit v1.2.3-70-g09d2