From 10f0d2ab9aa672707559d46601fd35544759ff70 Mon Sep 17 00:00:00 2001 From: Wan Jiabing Date: Thu, 28 Oct 2021 22:49:18 -0400 Subject: hwmon: (nct7802) Add of_node_put() before return Fix following coccicheck warning: ./drivers/hwmon/nct7802.c:1152:2-24: WARNING: Function for_each_child_of_node should have of_node_put() before return. Early exits from for_each_child_of_node should decrement the node reference counter. Signed-off-by: Wan Jiabing Link: https://lore.kernel.org/r/20211029024918.5161-1-wanjiabing@vivo.com Signed-off-by: Guenter Roeck --- drivers/hwmon/nct7802.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'drivers/hwmon/nct7802.c') diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c index d56f78327619..d1eeef02b6dc 100644 --- a/drivers/hwmon/nct7802.c +++ b/drivers/hwmon/nct7802.c @@ -1152,8 +1152,10 @@ static int nct7802_configure_channels(struct device *dev, for_each_child_of_node(dev->of_node, node) { err = nct7802_get_channel_config(dev, node, &mode_mask, &mode_val); - if (err) + if (err) { + of_node_put(node); return err; + } } } -- cgit v1.2.3-70-g09d2