From 0332967b4d657754c914b2a1951ae2d4ed3d99bd Mon Sep 17 00:00:00 2001 From: Josef Bacik Date: Wed, 20 Mar 2024 17:06:10 -0400 Subject: btrfs: unlock all the pages with successful inline extent creation Since 4750af3bbe5d ("btrfs: prevent extent_clear_unlock_delalloc() to unlock page not locked by __process_pages_contig()") we have been unlocking the locked page manually instead of via extent_clear_unlock_delalloc() because of subpage blocksize support. However we actually disable inline extent creation for subpage blocksize support, so this behavior isn't necessary. Remove this code and comment, if at some point the subpage blocksize code grows support for inline extents this can be re-evaluated. Reviewed-by: Johannes Thumshirn Signed-off-by: Josef Bacik Signed-off-by: David Sterba --- fs/btrfs/inode.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) (limited to 'fs') diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index fffa3d4015a3..477836cae06f 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -1358,24 +1358,11 @@ static noinline int cow_file_range(struct btrfs_inode *inode, * range. */ extent_clear_unlock_delalloc(inode, start, end, - locked_page, + NULL, EXTENT_LOCKED | EXTENT_DELALLOC | EXTENT_DELALLOC_NEW | EXTENT_DEFRAG | EXTENT_DO_ACCOUNTING, PAGE_UNLOCK | PAGE_START_WRITEBACK | PAGE_END_WRITEBACK); - /* - * locked_page is locked by the caller of - * writepage_delalloc(), not locked by - * __process_pages_contig(). - * - * We can't let __process_pages_contig() to unlock it, - * as it doesn't have any subpage::writers recorded. - * - * Here we manually unlock the page, since the caller - * can't determine if it's an inline extent or a - * compressed extent. - */ - unlock_page(locked_page); ret = 1; goto done; } else if (ret < 0) { -- cgit v1.2.3-70-g09d2