From 405b2a3ed380931225095c65c80eba7f11f0faa4 Mon Sep 17 00:00:00 2001
From: natrixaeria <upezu@student.kit.edu>
Date: Sat, 9 Nov 2019 01:50:51 +0100
Subject: Adapt exception messages

---
 kernel/src/interrupts/exceptions.rs | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

(limited to 'kernel/src/interrupts')

diff --git a/kernel/src/interrupts/exceptions.rs b/kernel/src/interrupts/exceptions.rs
index b6fb5a6..88c78a7 100644
--- a/kernel/src/interrupts/exceptions.rs
+++ b/kernel/src/interrupts/exceptions.rs
@@ -1,11 +1,19 @@
 use x86_64::structures::idt::{InterruptStackFrame, PageFaultErrorCode};
 
+macro_rules! exception_default {
+    ($stack_frame: expr) => {
+        format_args!("instruction addr: 0x{:08x}\nstack addr: 0x{:08x}\nflags: 0x{:x}",
+                    $stack_frame.instruction_pointer.as_u64(),
+                    $stack_frame.cpu_flags,
+                    $stack_frame.stack_pointer.as_u64()
+             )
+    }
+}
+
 pub extern "x86-interrupt" fn breakpoint_handler(stack_frame: &mut InterruptStackFrame) {
     panic!(
-        "BREAKPOINT at {:x} Flags: {:b} Stack: {:x}",
-        stack_frame.instruction_pointer.as_u64(),
-        stack_frame.cpu_flags,
-        stack_frame.stack_pointer.as_u64()
+        "BREAKPOINT exception thrown\n\n{}",
+        exception_default!(stack_frame)
     );
 }
 
@@ -16,11 +24,11 @@ pub extern "x86-interrupt" fn page_fault_handler(
     use x86_64::registers::control::Cr2;
 
     panic!(
-        "PAGE FAULT while accessing address: {:x}{:?}Flags: {:b} Stack: {:x}",
+        "PAGE FAULT while accessing address: 0x{:08x}\nerror code: {:?}(0x{:x})\n{}",
         Cr2::read().as_u64(),
         error_code,
-        stack_frame.cpu_flags,
-        stack_frame.stack_pointer.as_u64()
+        error_code.bits(),
+        exception_default!(stack_frame)
     );
 }
 
-- 
cgit v1.2.3-70-g09d2


From fdb9cbebc5eefbb89886eef86ab71dfac70cc39a Mon Sep 17 00:00:00 2001
From: natrixaeria <upezu@student.kit.edu>
Date: Sat, 9 Nov 2019 02:00:29 +0100
Subject: Add error messages

---
 kernel/src/interrupts/exceptions.rs | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

(limited to 'kernel/src/interrupts')

diff --git a/kernel/src/interrupts/exceptions.rs b/kernel/src/interrupts/exceptions.rs
index 88c78a7..057adbc 100644
--- a/kernel/src/interrupts/exceptions.rs
+++ b/kernel/src/interrupts/exceptions.rs
@@ -37,10 +37,9 @@ pub extern "x86-interrupt" fn segment_not_present_handler(
     error_code: u64,
 ) {
     panic!(
-        "SEGMENT NOT PRESENT: {:?}Flags: {:b} Stack: {:x}",
+        "SEGMENT NOT PRESENT exception\nerror code: 0x{:x}\n{}",
         error_code,
-        stack_frame.cpu_flags,
-        stack_frame.stack_pointer.as_u64()
+        exception_default!(stack_frame)
     );
 }
 
@@ -49,8 +48,7 @@ pub extern "x86-interrupt" fn double_fault_handler(
     _error_code: u64, // code is always zero
 ) {
     panic!(
-        "DOUBLE FAULT Flags: {:b} Stack: {:x}",
-        stack_frame.cpu_flags,
-        stack_frame.stack_pointer.as_u64()
+        "DOUBLE FAULT\nthis is a fatal exception\n{}",
+        exception_default!(stack_frame)
     );
 }
-- 
cgit v1.2.3-70-g09d2