diff options
author | msquare <msquare@notrademark.de> | 2016-09-29 11:18:17 +0200 |
---|---|---|
committer | msquare <msquare@notrademark.de> | 2016-09-29 11:18:17 +0200 |
commit | e965f8d04150fbd17ee1b5fcbca5ae85bbe6d6bd (patch) | |
tree | f610d047f1cdc830ffc34881f6ea6d26ef0e3983 /includes/model/NeededAngelTypes_model.php | |
parent | 91dafb19ec171e747d9976cf738606759bde3aae (diff) |
prohibit inline control structures on model and view
Diffstat (limited to 'includes/model/NeededAngelTypes_model.php')
-rw-r--r-- | includes/model/NeededAngelTypes_model.php | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/includes/model/NeededAngelTypes_model.php b/includes/model/NeededAngelTypes_model.php index 8d6b8cce..96ceca83 100644 --- a/includes/model/NeededAngelTypes_model.php +++ b/includes/model/NeededAngelTypes_model.php @@ -14,10 +14,11 @@ function NeededAngelTypes_by_shift($shiftId) { AND `count` > 0 ORDER BY `room_id` DESC "); - if ($needed_angeltypes_source === false) + if ($needed_angeltypes_source === false) { return false; - - // Use settings from room + } + + // Use settings from room if (count($needed_angeltypes_source) == 0) { $needed_angeltypes_source = sql_select(" SELECT `NeededAngelTypes`.*, `AngelTypes`.`name`, `AngelTypes`.`restricted` @@ -28,15 +29,17 @@ function NeededAngelTypes_by_shift($shiftId) { AND `count` > 0 ORDER BY `room_id` DESC "); - if ($needed_angeltypes_source === false) + if ($needed_angeltypes_source === false) { return false; + } } - $needed_angeltypes = array(); + $needed_angeltypes = []; foreach ($needed_angeltypes_source as $angeltype) { $shift_entries = ShiftEntries_by_shift_and_angeltype($shiftId, $angeltype['angel_type_id']); - if ($shift_entries === false) + if ($shift_entries === false) { return false; + } $angeltype['taken'] = count($shift_entries); $needed_angeltypes[] = $angeltype; |