3 files changed, 104 insertions, 11 deletions

diff --git a/tests/Unit/Routing/LegacyUrlGeneratorTest.php b/tests/Unit/Routing/LegacyUrlGeneratorTest.php
new file mode 100644
index 00000000..3d42afbd
--- /dev/null
+++ b/tests/Unit/Routing/LegacyUrlGeneratorTest.php
@@ -0,0 +1,54 @@
+<?php
+
+namespace Engelsystem\Test\Unit\Routing;
+
+use Engelsystem\Application;
+use Engelsystem\Container\Container;
+use Engelsystem\Http\Request;
+use Engelsystem\Routing\LegacyUrlGenerator;
+use Engelsystem\Routing\UrlGeneratorInterface;
+use PHPUnit\Framework\TestCase;
+
+class LegacyUrlGeneratorTest extends TestCase
+{
+    public function provideLinksTo()
+    {
+        return [
+            ['/', 'http://foo.bar/index.php', [], 'http://foo.bar/'],
+            ['/foo-path', 'http://foo.bar/index.php/index.php', [], 'http://foo.bar/index.php?p=foo_path'],
+            ['/foo', 'http://foo.bar/index.php/index.php', [], 'http://foo.bar/index.php?p=foo'],
+            ['foo', 'http://foo.bar/index.php', ['test' => 'abc'], 'http://foo.bar/index.php?p=foo&test=abc'],
+        ];
+    }
+
+    /**
+     * @dataProvider provideLinksTo
+     * @covers       \Engelsystem\Routing\LegacyUrlGenerator::linkTo
+     *
+     * @param string   $urlToPath
+     * @param string   $willReturn
+     * @param string[] $arguments
+     * @param string   $expectedUrl
+     */
+    public function testLinkTo($urlToPath, $willReturn, $arguments, $expectedUrl)
+    {
+        $app = new Container();
+        Application::setInstance($app);
+
+        $request = $this->getMockBuilder(Request::class)
+            ->getMock();
+
+        $request->expects($this->once())
+            ->method('getUriForPath')
+            ->with('/index.php')
+            ->willReturn($willReturn);
+
+        $app->instance('request', $request);
+
+        $urlGenerator = new LegacyUrlGenerator();
+        $this->assertInstanceOf(UrlGeneratorInterface::class, $urlGenerator);
+
+        $url = $urlGenerator->linkTo($urlToPath, $arguments);
+        $this->assertEquals($expectedUrl, $url);
+    }
+}
diff --git a/tests/Unit/Routing/RoutingServiceProviderTest.php b/tests/Unit/Routing/RoutingServiceProviderTest.php
index dd9441eb..ce3d7290 100644
--- a/tests/Unit/Routing/RoutingServiceProviderTest.php
+++ b/tests/Unit/Routing/RoutingServiceProviderTest.php
@@ -2,10 +2,13 @@
 
 namespace Engelsystem\Test\Unit\Routing;
 
+use Engelsystem\Config\Config;
+use Engelsystem\Routing\LegacyUrlGenerator;
 use Engelsystem\Routing\RoutingServiceProvider;
 use Engelsystem\Routing\UrlGenerator;
+use Engelsystem\Routing\UrlGeneratorInterface;
 use Engelsystem\Test\Unit\ServiceProviderTest;
-use PHPUnit_Framework_MockObject_MockObject;
+use PHPUnit_Framework_MockObject_MockObject as MockObject;
 
 class RoutingServiceProviderTest extends ServiceProviderTest
 {
@@ -14,16 +17,48 @@ class RoutingServiceProviderTest extends ServiceProviderTest
      */
     public function testRegister()
     {
-        /** @var PHPUnit_Framework_MockObject_MockObject|UrlGenerator $urlGenerator */
-        $urlGenerator = $this->getMockBuilder(UrlGenerator::class)
-            ->getMock();
+        $app = $this->getApp(['make', 'instance', 'bind', 'get']);
+        /** @var MockObject|Config $config */
+        $config = $this->getMockBuilder(Config::class)->getMock();
+        /** @var MockObject|UrlGeneratorInterface $urlGenerator */
+        $urlGenerator = $this->getMockForAbstractClass(UrlGeneratorInterface::class);
+        /** @var MockObject|UrlGeneratorInterface $legacyUrlGenerator */
+        $legacyUrlGenerator = $this->getMockForAbstractClass(UrlGeneratorInterface::class);
 
-        $app = $this->getApp();
+        $config->expects($this->atLeastOnce())
+            ->method('get')
+            ->with('rewrite_urls')
+            ->willReturnOnConsecutiveCalls(
+                true,
+                false
+            );
 
-        $this->setExpects($app, 'make', [UrlGenerator::class], $urlGenerator);
-        $this->setExpects($app, 'instance', ['routing.urlGenerator', $urlGenerator]);
+        $this->setExpects($app, 'get', ['config'], $config, $this->atLeastOnce());
+
+        $app->expects($this->atLeastOnce())
+            ->method('make')
+            ->withConsecutive(
+                [UrlGenerator::class],
+                [LegacyUrlGenerator::class]
+            )
+            ->willReturnOnConsecutiveCalls(
+                $urlGenerator,
+                $legacyUrlGenerator
+            );
+        $app->expects($this->atLeastOnce())
+            ->method('instance')
+            ->withConsecutive(
+                ['routing.urlGenerator', $urlGenerator],
+                ['routing.urlGenerator', $legacyUrlGenerator]
+            );
+        $this->setExpects(
+            $app, 'bind',
+            [UrlGeneratorInterface::class, 'routing.urlGenerator'], null,
+            $this->atLeastOnce()
+        );
 
         $serviceProvider = new RoutingServiceProvider($app);
         $serviceProvider->register();
+        $serviceProvider->register();
     }
 }
diff --git a/tests/Unit/Routing/UrlGeneratorTest.php b/tests/Unit/Routing/UrlGeneratorTest.php
index 6da59a4f..e128bfe7 100644
--- a/tests/Unit/Routing/UrlGeneratorTest.php
+++ b/tests/Unit/Routing/UrlGeneratorTest.php
@@ -6,6 +6,7 @@ use Engelsystem\Application;
 use Engelsystem\Container\Container;
 use Engelsystem\Http\Request;
 use Engelsystem\Routing\UrlGenerator;
+use Engelsystem\Routing\UrlGeneratorInterface;
 use PHPUnit\Framework\TestCase;
 
 class UrlGeneratorTest extends TestCase
@@ -13,6 +14,7 @@ class UrlGeneratorTest extends TestCase
     public function provideLinksTo()
     {
         return [
+            ['/', '/', 'http://foo.bar/', [], 'http://foo.bar/'],
             ['/foo/path', '/foo/path', 'http://foo.bar/foo/path', [], 'http://foo.bar/foo/path'],
             ['foo', '/foo', 'https://foo.bar/foo', [], 'https://foo.bar/foo'],
             ['foo', '/foo', 'http://f.b/foo', ['test' => 'abc', 'bla' => 'foo'], 'http://f.b/foo?test=abc&bla=foo'],
@@ -21,7 +23,7 @@ class UrlGeneratorTest extends TestCase
 
     /**
      * @dataProvider provideLinksTo
-     * @covers       \Engelsystem\Routing\UrlGenerator::to
+     * @covers       \Engelsystem\Routing\UrlGenerator::linkTo
      *
      * @param string   $path
      * @param string   $willReturn
@@ -29,10 +31,9 @@ class UrlGeneratorTest extends TestCase
      * @param string[] $arguments
      * @param string   $expectedUrl
      */
-    public function testTo($urlToPath, $path, $willReturn, $arguments, $expectedUrl)
+    public function testLinkTo($urlToPath, $path, $willReturn, $arguments, $expectedUrl)
     {
         $app = new Container();
-        $urlGenerator = new UrlGenerator();
         Application::setInstance($app);
 
         $request = $this->getMockBuilder(Request::class)
@@ -45,7 +46,10 @@ class UrlGeneratorTest extends TestCase
 
         $app->instance('request', $request);
 
-        $url = $urlGenerator->to($urlToPath, $arguments);
+        $urlGenerator = new UrlGenerator();
+        $this->assertInstanceOf(UrlGeneratorInterface::class, $urlGenerator);
+
+        $url = $urlGenerator->linkTo($urlToPath, $arguments);
         $this->assertEquals($expectedUrl, $url);
     }
 }