From 91dafb19ec171e747d9976cf738606759bde3aae Mon Sep 17 00:00:00 2001
From: msquare <msquare@notrademark.de>
Date: Thu, 29 Sep 2016 10:53:17 +0200
Subject: prohibit inline control structures on pages

---
 includes/pages/user_questions.php | 26 ++++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

(limited to 'includes/pages/user_questions.php')

diff --git a/includes/pages/user_questions.php b/includes/pages/user_questions.php
index 0a2786d1..6d9ded8e 100644
--- a/includes/pages/user_questions.php
+++ b/includes/pages/user_questions.php
@@ -1,4 +1,5 @@
 <?php
+
 function questions_title() {
   return _("Ask an archangel");
 }
@@ -12,8 +13,9 @@ function user_questions() {
     $answered_questions = sql_select("SELECT * FROM `Questions` WHERE NOT `AID` IS NULL AND `UID`='" . sql_escape($user['UID']) . "'");
     foreach ($answered_questions as &$question) {
       $answer_user_source = User($question['AID']);
-      if ($answer_user_source === false)
+      if ($answer_user_source === false) {
         engelsystem_error(_("Unable to load user."));
+      }
       $question['answer_user'] = User_Nick_render($answer_user_source);
     }
     
@@ -24,29 +26,33 @@ function user_questions() {
         $question = strip_request_item_nl('question');
         if ($question != "") {
           $result = sql_query("INSERT INTO `Questions` SET `UID`='" . sql_escape($user['UID']) . "', `Question`='" . sql_escape($question) . "'");
-          if ($result === false)
+          if ($result === false) {
             engelsystem_error(_("Unable to save question."));
+          }
           success(_("You question was saved."));
           redirect(page_link_to("user_questions"));
-        } else
-          return page_with_title(questions_title(), array(
+        } else {
+          return page_with_title(questions_title(), [
               error(_("Please enter a question!"), true) 
-          ));
+          ]);
+        }
         break;
       case 'delete':
-        if (isset($_REQUEST['id']) && preg_match("/^[0-9]{1,11}$/", $_REQUEST['id']))
+        if (isset($_REQUEST['id']) && preg_match("/^[0-9]{1,11}$/", $_REQUEST['id'])) {
           $id = $_REQUEST['id'];
-        else
+        } else {
           return error(_("Incomplete call, missing Question ID."), true);
+        }
         
         $question = sql_select("SELECT * FROM `Questions` WHERE `QID`='" . sql_escape($id) . "' LIMIT 1");
         if (count($question) > 0 && $question[0]['UID'] == $user['UID']) {
           sql_query("DELETE FROM `Questions` WHERE `QID`='" . sql_escape($id) . "' LIMIT 1");
           redirect(page_link_to("user_questions"));
-        } else
-          return page_with_title(questions_title(), array(
+        } else {
+          return page_with_title(questions_title(), [
               error(_("No question found."), true) 
-          ));
+          ]);
+        }
         break;
     }
   }
-- 
cgit v1.2.3-54-g00ecf