From b878740f80ce7cfe2a0bc53956e3f7e4e0aa2f78 Mon Sep 17 00:00:00 2001 From: Igor Scheller Date: Sun, 10 Nov 2019 21:30:26 +0100 Subject: News: Bug fixes, cleanup, comments & formatting Use more magically available methods and properties Fixed atom feed and stats not using the new model --- src/Controllers/Metrics/Stats.php | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) (limited to 'src/Controllers/Metrics') diff --git a/src/Controllers/Metrics/Stats.php b/src/Controllers/Metrics/Stats.php index af453cde..2d58f999 100644 --- a/src/Controllers/Metrics/Stats.php +++ b/src/Controllers/Metrics/Stats.php @@ -5,6 +5,7 @@ namespace Engelsystem\Controllers\Metrics; use Carbon\Carbon; use Engelsystem\Database\Database; use Engelsystem\Models\EventConfig; +use Engelsystem\Models\News; use Illuminate\Database\Query\Builder as QueryBuilder; use Illuminate\Database\Query\Expression as QueryExpression; @@ -209,16 +210,10 @@ class Stats /** * @param bool $meeting * @return int - * @codeCoverageIgnore */ public function announcements($meeting = null) { - $query = $this - ->getQuery('News'); - - if (!is_null($meeting)) { - $query->where('Treffen', '=', $meeting); - } + $query = is_null($meeting) ? News::query() : News::whereIsMeeting($meeting); return $query->count(); } -- cgit v1.2.3-54-g00ecf