diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-09-09 12:14:40 +0300 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2021-09-13 17:04:03 +0200 |
| commit | 0bd46e22c5ec3dbfb81b60de475151e3f6b411c2 (patch) | |
| tree | 01e838e1b3ef5deabfa6bc3ad037cdd6586020d5 | |
| parent | 67f3b2f822b7e71cfc9b42dbd9f3144fa2933e0b (diff) | |
nvmet: fix a width vs precision bug in nvmet_subsys_attr_serial_show()
This was intended to limit the number of characters printed from
"subsys->serial" to NVMET_SN_MAX_SIZE. But accidentally the width
specifier was used instead of the precision specifier so it only
affects the alignment and not the number of characters printed.
Fixes: f04064814c2a ("nvmet: fixup buffer overrun in nvmet_subsys_attr_serial()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
| -rw-r--r-- | drivers/nvme/target/configfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c index d784f3c200b4..be5d82421e3a 100644 --- a/drivers/nvme/target/configfs.c +++ b/drivers/nvme/target/configfs.c @@ -1067,7 +1067,7 @@ static ssize_t nvmet_subsys_attr_serial_show(struct config_item *item, { struct nvmet_subsys *subsys = to_subsys(item); - return snprintf(page, PAGE_SIZE, "%*s\n", + return snprintf(page, PAGE_SIZE, "%.*s\n", NVMET_SN_MAX_SIZE, subsys->serial); } |