diff options
| author | Christian Brauner <brauner@kernel.org> | 2023-10-24 16:53:41 +0200 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2023-11-18 14:59:24 +0100 |
| commit | 218de67764e5c4682892427dd78b382e1709674c (patch) | |
| tree | 0c8345b3974533df78c69e726b64eb8502fdb6e2 | |
| parent | 653bee386c0875016cb36ed50f00bb0d8a7fcc7f (diff) | |
ext4: simplify device handling
We removed all codepaths where s_umount is taken beneath open_mutex and
bd_holder_lock so don't make things more complicated than they need to
be and hold s_umount over block device opening.
Link: https://lore.kernel.org/r/20231024-vfs-super-rework-v1-3-37a8aa697148@kernel.org
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
| -rw-r--r-- | fs/ext4/super.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index c5fcf377ab1f..bd752f3f1dd5 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -5864,11 +5864,8 @@ static struct bdev_handle *ext4_get_journal_blkdev(struct super_block *sb, struct ext4_super_block *es; int errno; - /* see get_tree_bdev why this is needed and safe */ - up_write(&sb->s_umount); bdev_handle = bdev_open_by_dev(j_dev, BLK_OPEN_READ | BLK_OPEN_WRITE, sb, &fs_holder_ops); - down_write(&sb->s_umount); if (IS_ERR(bdev_handle)) { ext4_msg(sb, KERN_ERR, "failed to open journal device unknown-block(%u,%u) %ld", |