diff options
| author | Carlos Santa <carlos.santa@intel.com> | 2023-10-26 15:01:27 -0700 |
|---|---|---|
| committer | Rodrigo Vivi <rodrigo.vivi@intel.com> | 2023-12-21 11:43:33 -0500 |
| commit | 27a1a1e2e47d6f12a784413c194a94b6c0d7fdcb (patch) | |
| tree | 15c057ffb94aabd42d33c4bd5ec7b27fd7711d99 | |
| parent | 5d30cfe003a98d2f4ad28fe27226f3f2e6784c65 (diff) | |
drm/xe: stringify the argument to avoid potential vulnerability
This error gets printed inside a sandbox with warnings turned on.
/mnt/host/source/src/third_party/kernel/v5.15/drivers/
gpu/drm/xe/xe_gt_idle_sysfs.c:87:26: error: format string is
not a string literal (potentially insecure) [-Werror,-Wformat-security]
return sysfs_emit(buff, gtidle->name);
^~~~~~~~~~~~
/mnt/host/source/src/third_party/kernel/v5.15/drivers/
gpu/drm/xe/xe_gt_idle_sysfs.c:87:26: note: treat the string
as an argument to avoid this
return sysfs_emit(buff, gtidle->name);
^
"%s",
1 error generated.
CC: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Carlos Santa <carlos.santa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
| -rw-r--r-- | drivers/gpu/drm/xe/xe_gt_idle_sysfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/xe/xe_gt_idle_sysfs.c b/drivers/gpu/drm/xe/xe_gt_idle_sysfs.c index 7238e96a116c..8df9840811cd 100644 --- a/drivers/gpu/drm/xe/xe_gt_idle_sysfs.c +++ b/drivers/gpu/drm/xe/xe_gt_idle_sysfs.c @@ -85,7 +85,7 @@ static ssize_t name_show(struct device *dev, { struct xe_gt_idle *gtidle = dev_to_gtidle(dev); - return sysfs_emit(buff, gtidle->name); + return sysfs_emit(buff, "%s\n", gtidle->name); } static DEVICE_ATTR_RO(name); |