summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2024-08-09 15:28:30 +0300
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2024-08-10 11:22:11 +0100
commit4f6ca3464d987054f5e75f097a97dcbb86a87569 (patch)
treeaa3acc3b240b50a06ebd06ee09a45130f6557b21
parentb09999ee1e86a19d43eb6818daa69e577c2fb77a (diff)
iio: dac: ltc2664: Fix off by one in ltc2664_channel_config()
This comparison should be >= ARRAY_SIZE() instead of >. The "mspan" variable is later used as an array index into ltc2664_mspan_lut[] so this is an off by one bug. Fixes: 4cc2fc445d2e ("iio: dac: ltc2664: Add driver for LTC2664 and LTC2672") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://patch.msgid.link/5727ab54-6280-466e-b107-1b6006e5ab29@stanley.mountain Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
-rw-r--r--drivers/iio/dac/ltc2664.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/dac/ltc2664.c b/drivers/iio/dac/ltc2664.c
index 666ecdeb5f96..5be5345ac5c8 100644
--- a/drivers/iio/dac/ltc2664.c
+++ b/drivers/iio/dac/ltc2664.c
@@ -526,7 +526,7 @@ static int ltc2664_channel_config(struct ltc2664_state *st)
return dev_err_probe(dev, -EINVAL,
"adi,manual-span-operation-config not supported\n");
- if (mspan > ARRAY_SIZE(ltc2664_mspan_lut))
+ if (mspan >= ARRAY_SIZE(ltc2664_mspan_lut))
return dev_err_probe(dev, -EINVAL,
"adi,manual-span-operation-config not in range\n");
}