diff options
| author | Josef Bacik <josef@toxicpanda.com> | 2024-05-07 14:12:15 -0400 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2024-07-11 15:33:25 +0200 |
| commit | 5eb178f373b4f16f3b42d55ff88fc94dd95b93b1 (patch) | |
| tree | d2d231fcb5a43302a6be32525fc5feb123d6f9c5 | |
| parent | f9c5b70c99ab6db06236d5ce337cf427aed32e49 (diff) | |
btrfs: handle errors from btrfs_dec_ref() properly
In walk_up_proc() we BUG_ON(ret) from btrfs_dec_ref(). This is
incorrect, we have proper error handling here, return the error.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/extent-tree.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index d1c9158bf3e0..ec3080664bb6 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -5802,7 +5802,10 @@ static noinline int walk_up_proc(struct btrfs_trans_handle *trans, ret = btrfs_dec_ref(trans, root, eb, 1); else ret = btrfs_dec_ref(trans, root, eb, 0); - BUG_ON(ret); /* -ENOMEM */ + if (ret) { + btrfs_abort_transaction(trans, ret); + return ret; + } if (is_fstree(btrfs_root_id(root))) { ret = btrfs_qgroup_trace_leaf_items(trans, eb); if (ret) { |