diff options
| author | H Hartley Sweeten <hartleys@visionengravers.com> | 2012-09-24 13:50:48 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-09-26 10:21:43 -0700 |
| commit | 67f2021fb1519057b0643d871b2afcd583bcc40d (patch) | |
| tree | 9f5d4d499ed2e0985b5a95ffcec2b69a1cf4d71a | |
| parent | 54a2a02ea51f606ba37f800c5e5eebb049ca6fb8 (diff) | |
staging: comedi: s526: fix if() check in s526_gpct_winsn()
This if() check was flipped from a test for valid data params
to a test for invalid params.
As pointed out by Dan Carpenter, the orignal test was:
if ((data[1] > data[0]) && (data[0] > 0)) {
the flipped test should be:
if (data[1] <= data[0]) ...
Add the missing '='.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/comedi/drivers/s526.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/comedi/drivers/s526.c b/drivers/staging/comedi/drivers/s526.c index 4ad6adfcbb9c..a1e256293bd6 100644 --- a/drivers/staging/comedi/drivers/s526.c +++ b/drivers/staging/comedi/drivers/s526.c @@ -376,7 +376,7 @@ static int s526_gpct_winsn(struct comedi_device *dev, The above periods must be expressed as a multiple of the pulse frequency on the selected source */ - if ((data[1] < data[0]) || !data[0]) + if ((data[1] <= data[0]) || !data[0]) return -EINVAL; /* Fall thru to write the PULSE_WIDTH */ |