diff options
author | Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com> | 2021-11-29 14:20:08 -0500 |
---|---|---|
committer | Jason Gunthorpe <jgg@nvidia.com> | 2021-12-07 13:22:54 -0400 |
commit | 60a8b5a1611b4a26de4839ab9c1fc2a9cf3e17c1 (patch) | |
tree | 748f62331ec58e2baba87b5c119085b493f1e0e4 /COPYING | |
parent | f6a3cfec3c01f9983e961c3327cef0db129a3c43 (diff) |
IB/hfi1: Fix leak of rcvhdrtail_dummy_kvaddr
This buffer is currently allocated in hfi1_init():
if (reinit)
ret = init_after_reset(dd);
else
ret = loadtime_init(dd);
if (ret)
goto done;
/* allocate dummy tail memory for all receive contexts */
dd->rcvhdrtail_dummy_kvaddr = dma_alloc_coherent(&dd->pcidev->dev,
sizeof(u64),
&dd->rcvhdrtail_dummy_dma,
GFP_KERNEL);
if (!dd->rcvhdrtail_dummy_kvaddr) {
dd_dev_err(dd, "cannot allocate dummy tail memory\n");
ret = -ENOMEM;
goto done;
}
The reinit triggered path will overwrite the old allocation and leak it.
Fix by moving the allocation to hfi1_alloc_devdata() and the deallocation
to hfi1_free_devdata().
Link: https://lore.kernel.org/r/20211129192008.101968.91302.stgit@awfm-01.cornelisnetworks.com
Cc: stable@vger.kernel.org
Fixes: 46b010d3eeb8 ("staging/rdma/hfi1: Workaround to prevent corruption during packet delivery")
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions